Remove remaining PrimeVue 3 specific components and CSS, and improve score set and experiment validator error handling #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency and to avoid any confusion during debugging, component names are being changes to match their file names.
…toComplete Also updates styling of publication identifers AutoComplete chips to match the others on this page.
…ditor AutoComplete components
…PrimeVue4 styling
…Primevue 4 styling Also prevent closing parent Dialog components on escape because escape already has defined behavior on AutoCompletes within CalibrationEditor.
…ges on ScoreSetCalibrationsView
…ors to match existing site
…maining components
…ove handling of validation errors
…edFields object to avoid changing values on form
…anup The path value for validation errors within the targetGenes portion of the form were not correctly matched with the API validation error responses and the structure of the form data. Updating throughout for consistency and to ensure validation errors result in redirecting the user to the relevant page and prompting on the appropriate field(s). This corresponds with VariantEffect/mavedb-api@6ae0d32 This commit also includes some cleanup of previously commented out code and updates the disabled logic on file uploads to ensure they are properly enabled after failed validations elsewhere on the form.
…nality and reduce overlap The ExperimentCreator had some logic related to editing existing experiments which is being removed. Similarly, the ExperimentEditor component had some logic for creating experiments which was still being used when adding new experiments to an existing experiment set. With this change, the ExperimentCreator will be used for creating all new experiments, and the ExperimentEditor will only be used for editing existing experiments with any code extraneous to those functions has been removed.
bencap
reviewed
Jan 6, 2026
Collaborator
bencap
left a comment
bencap
left a comment
There was a problem hiding this comment.
Looks great overall, and thanks again for all the work on this Primevue upgrade.
Main blocking issue:
- The score column metadata and count column metadata file uploads remain disabled even after adding a score / count file.
A couple other small things I noticed, all minor:
- The tag text color isn't white anymore, which reduces contrast (see https://127.0.0.1:8081/score-sets/urn:mavedb:00000097-0-2?calibration=urn:mavedb:calibration-53755a6c-426b-42f4-b771-80283ac41aa2)
- OrcID elements for creators and modifiers, plus elements like the UCSC logo are on different lines from their associated text (see https://127.0.0.1:8081/score-sets/urn:mavedb:00000097-s-1).
- The 'Back' button color on the score set creator and experiment creator makes it look disabled.
- On the score set creator (and other places with the toggle switch) the text at right of all the toggle switches is no longer center aligned.
- I think the messages would look better with a small top margin (top of the score set information page, when selecting a non-default license, top of the page for score sets with mapping issues, etc.).
- I still see the
Usersitem in the toolbar even though the component was removed. - The 'Close' button color on the score calibration creator makes it look disabled.
- When editing a score set, the message for autopopulating fields still shows up but that probably isn't relevant outside of the score set creator (this might be a problem unrelated to your changes).
…SetCreator Previously this was using properties of $refs to conditionally disable FileUpload components, but $refs are not reactive so the values were not updating correctly with this logic (a prior version also used $refs, but was not updating after form validation errors). For this reason, now switching to defined data variables to track the current count of files for each FileUpload component on the final step of the wizard, and removing use of $refs.
…PrimeVue 4 upgrade - Change the MaveDB tag text to white on ScoreSetView - Put OrcID elements for creators and modifiers and UCSC logo on same lines as their associated text on ScoreSetView - Customize theme to make secondary buttons pink to match previous style, otherwise their appearance is similar to that of disabled buttons - Align ToggleSwitch labels with switches where they are misaligned - Add top and bottom margin to .p-message class in app.css - Remove 'Users' from toolbar - Remove message for autopopulating fields on ScoreSetEditor, since it's only relevant to ScoreSetEditor
Contributor
Author
|
Thanks for the feedback @bencap . I addressed your comments, so let me know if those parts look better now and if there's anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch completes the migration to PrimeVue 4 by replacing any remaining components from PrimeVue 3 that are marked as deprecated or have been renamed, to cover all of the items in the migration guide found here: https://primevue.org/guides/migration/v4
In addition, some improvements have been made on logic and display of validation errors for the
ScoreSetCreator,ScoreSetEditorcomponents, and in the separation of functionality for theExperimentCreatorandExperimentEditorcomponents.Goes with VariantEffect/mavedb-api#635