Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions florist/api/servers/config_parsers.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

from typing_extensions import Self

from florist.api.servers.exceptions import IncompleteConfigError


class BasicConfigParser:
"""Parser for basic server configurations."""
Expand Down Expand Up @@ -101,9 +103,3 @@ def list(cls) -> List[str]:
:return: (List[str]) a list of supported config parsers.
"""
return [config_parser.value for config_parser in ConfigParser]


class IncompleteConfigError(Exception):
"""Defines errors in server config strings that have incomplete information."""

pass
7 changes: 7 additions & 0 deletions florist/api/servers/exceptions.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
"""Exceptions for servers' construction."""


class IncompleteConfigError(BaseException):
"""Defines errors in server config strings that have incomplete information."""

pass
4 changes: 2 additions & 2 deletions florist/tests/unit/api/servers/test_config_parsers.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import json
from pytest import raises

from florist.api.servers.config_parsers import ConfigParser, IncompleteConfigError

from florist.api.servers.config_parsers import ConfigParser
from florist.api.servers.exceptions import IncompleteConfigError

def test_parse_basic_config_success() -> None:
test_config = {"n_server_rounds": 123, "batch_size": 456, "local_epochs": 789}
Expand Down