pdf-parser: Store Name as Vec<u8> and skip comments in arrays/dicts#90
Merged
pdf-parser: Store Name as Vec<u8> and skip comments in arrays/dicts#90
Conversation
Change ObjectVariant::Name from String to Vec<u8> to preserve raw bytes and avoid lossy Latin-1 interpretation of #HH hex escapes. Dictionary keys are converted to String at the parsing boundary since PDF spec requires them to be ASCII. Replace skip_whitespace() with skip_whitespace_and_comments() in array and dictionary parsers so that PDF comments between elements are properly consumed instead of causing parse errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Velli20
force-pushed
the
parser-fixes-4
branch
from
8a4012b to
5db118f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change ObjectVariant::Name from String to Vec to preserve raw bytes and avoid lossy Latin-1 interpretation of #HH hex escapes. Dictionary keys are converted to String at the parsing boundary since PDF spec requires them to be ASCII.
Replace skip_whitespace() with skip_whitespace_and_comments() in array and dictionary parsers so that PDF comments between elements are properly consumed instead of causing parse errors.