Skip to content

pdf-page: Fix image decoding correctness bugs#92

Merged
Velli20 merged 1 commit intomainfrom
image-fix
Feb 17, 2026
Merged

pdf-page: Fix image decoding correctness bugs#92
Velli20 merged 1 commit intomainfrom
image-fix

Conversation

@Velli20
Copy link
Owner

@Velli20 Velli20 commented Feb 17, 2026

  • Use color_space.num_color_components() instead of inferring component count from raw data length, which was wrong for non-8bpc images
  • Add explicit UnsupportedBitsPerComponent error for BitsPerComponent != 8 instead of silently producing garbage output
  • Fix CMYK images: 4-component arm in to_rgba now converts CMYK→RGBA instead of treating the K channel as alpha
  • Fix Indexed color space: expand palette indices at parse time via expand_indexed(), and store the base color space (not the Indexed wrapper). Keeping the Indexed wrapper caused resolve_image_data in the canvas layer to re-expand already-decoded pixel data, producing a buffer too small for the declared RGBA8888 format and causing Skia to fail with "failed to create raster image from data (NxN)"
  • Rename PixelFormat::Alpha8 → Gray8 (it was already mapped to Skia's Gray8 color type; the name was just wrong)
  • Fix fallback arm in to_rgba: use chunks_exact(num_color_components) to stay within each pixel's bytes instead of reading across pixel boundaries
  • Add ZeroImageDimensions and ZeroColorComponents error variants; remove dead #[from] on Box in SMaskReadError

- Use color_space.num_color_components() instead of inferring component
  count from raw data length, which was wrong for non-8bpc images
- Add explicit UnsupportedBitsPerComponent error for BitsPerComponent != 8
  instead of silently producing garbage output
- Fix CMYK images: 4-component arm in to_rgba now converts CMYK→RGBA
  instead of treating the K channel as alpha
- Fix Indexed color space: expand palette indices at parse time via
  expand_indexed(), and store the base color space (not the Indexed
  wrapper). Keeping the Indexed wrapper caused resolve_image_data in the
  canvas layer to re-expand already-decoded pixel data, producing a buffer
  too small for the declared RGBA8888 format and causing Skia to fail with
  "failed to create raster image from data (NxN)"
- Rename PixelFormat::Alpha8 → Gray8 (it was already mapped to Skia's
  Gray8 color type; the name was just wrong)
- Fix fallback arm in to_rgba: use chunks_exact(num_color_components) to
  stay within each pixel's bytes instead of reading across pixel boundaries
- Add ZeroImageDimensions and ZeroColorComponents error variants; remove
  dead #[from] on Box<XObjectError> in SMaskReadError

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Velli20 Velli20 merged commit 6d45255 into main Feb 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant