Conversation
Owner
Velli20
commented
Feb 17, 2026
- Use color_space.num_color_components() instead of inferring component count from raw data length, which was wrong for non-8bpc images
- Add explicit UnsupportedBitsPerComponent error for BitsPerComponent != 8 instead of silently producing garbage output
- Fix CMYK images: 4-component arm in to_rgba now converts CMYK→RGBA instead of treating the K channel as alpha
- Fix Indexed color space: expand palette indices at parse time via expand_indexed(), and store the base color space (not the Indexed wrapper). Keeping the Indexed wrapper caused resolve_image_data in the canvas layer to re-expand already-decoded pixel data, producing a buffer too small for the declared RGBA8888 format and causing Skia to fail with "failed to create raster image from data (NxN)"
- Rename PixelFormat::Alpha8 → Gray8 (it was already mapped to Skia's Gray8 color type; the name was just wrong)
- Fix fallback arm in to_rgba: use chunks_exact(num_color_components) to stay within each pixel's bytes instead of reading across pixel boundaries
- Add ZeroImageDimensions and ZeroColorComponents error variants; remove dead #[from] on Box in SMaskReadError
- Use color_space.num_color_components() instead of inferring component count from raw data length, which was wrong for non-8bpc images - Add explicit UnsupportedBitsPerComponent error for BitsPerComponent != 8 instead of silently producing garbage output - Fix CMYK images: 4-component arm in to_rgba now converts CMYK→RGBA instead of treating the K channel as alpha - Fix Indexed color space: expand palette indices at parse time via expand_indexed(), and store the base color space (not the Indexed wrapper). Keeping the Indexed wrapper caused resolve_image_data in the canvas layer to re-expand already-decoded pixel data, producing a buffer too small for the declared RGBA8888 format and causing Skia to fail with "failed to create raster image from data (NxN)" - Rename PixelFormat::Alpha8 → Gray8 (it was already mapped to Skia's Gray8 color type; the name was just wrong) - Fix fallback arm in to_rgba: use chunks_exact(num_color_components) to stay within each pixel's bytes instead of reading across pixel boundaries - Add ZeroImageDimensions and ZeroColorComponents error variants; remove dead #[from] on Box<XObjectError> in SMaskReadError Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.