Skip to content

Conversation

@reece394
Copy link
Contributor

Fixes duplicate browser entries introduced by #45 including duplicate entries for Zen, Google Chrome, Chromium, Edge, Opera Stable and Comodo Dragon. Fixed the Browser path for Yandex Browser and added systemprofile support for them. Also fixes the VQL in Firefox_HistoryLegacy.yaml to remove the Description field from the Regex search which does not exist in the definition.

@scudette
Copy link
Contributor

I wonder if it's worth replacing all the variations of browsers with a wild card. I think the final glob is robust enough to not have too many false positives

@reece394
Copy link
Contributor Author

reece394 commented Jan 22, 2026

We could do this as most of them follow the

AppData\{Roaming,Local}\*\User Data, AppData\{Roaming,Local}\*\*\User Data, AppData\{Roaming,Local}\*\*\Profiles and AppData\{Roaming,Local}\*\Profiles. 

I would be more worried on bigger systems about the performance impact of moving the glob to the AppData folder if there is a huge number of users on the system and a lot of applications as that could slow things down a lot more than they are now.

@scudette
Copy link
Contributor

Performance wise it makes no difference as the glob will match the same number of files

(it might actually be faster with one wildcard rather than multiple alternatives).

@reece394
Copy link
Contributor Author

@scudette this should be much cleaner now. Kept some of them in that were edge cases. If we find more that behave the same way then I can add more wildcard globs

@scudette scudette merged commit 2fe137c into Velocidex:master Jan 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants