introduce VMAnomalyModel and VMAnomalyScheduler#1472
Open
AndrewChubatiuk wants to merge 1 commit intomasterfrom
Open
introduce VMAnomalyModel and VMAnomalyScheduler#1472AndrewChubatiuk wants to merge 1 commit intomasterfrom
AndrewChubatiuk wants to merge 1 commit intomasterfrom
Conversation
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
2 times, most recently
from
7b569bb to
a7fc951
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
3 times, most recently
from
840964f to
9e5ab0f
Compare
f41gh7
requested changes
Jul 18, 2025
Collaborator
f41gh7
left a comment
f41gh7
left a comment
There was a problem hiding this comment.
It's required to add documentation in first place. Is it possible that model could interfere on each other? Is it required to config VMAnomaly itself somehow? What is a relations between VMAnomaly and VMAnomalyModel?
Currently it's not possible to use this new API.
Also, I suggest to add -configCheckInterval to the vmanomaly in the same way as other components have it. It solves configuration reload without need of external config reloaders.
Contributor
Author
|
removed config reloader since python watchdog, which implements hot reload listens to fs events |
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
from
0ec9f87 to
1ba5e13
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
from
1ba5e13 to
4558e7c
Compare
AndrewChubatiuk
changed the title
Contributor
Author
|
added scheduler CR, added docs |
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
5 times, most recently
from
1b8eb91 to
2216f0a
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
from
2216f0a to
d0a06c0
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
2 times, most recently
from
66eac73 to
bfc5203
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
5 times, most recently
from
cdea53b to
5914c18
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
from
4573011 to
b08cb77
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
from
b08cb77 to
bf2eac2
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
from
bf2eac2 to
1b8d0ca
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
2 times, most recently
from
a757c9e to
30c4e13
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
from
30c4e13 to
96dc1df
Compare
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
from
96dc1df to
9d58b90
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 36 out of 36 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndrewChubatiuk
force-pushed
the
introduce-vmanomalymodel
branch
from
9d58b90 to
11c333c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
starting 1.25.0 anomaly supports hot-reload, adding VMAnomalyModel and VMAnomalyScheduler CRs for VMAnomaly dynamic configuration