convert: support prom alertmanagerconfig spec.muteTimeIntervals conve…#1784
Open
AndrewChubatiuk wants to merge 2 commits intomasterfrom
Open
convert: support prom alertmanagerconfig spec.muteTimeIntervals conve…#1784AndrewChubatiuk wants to merge 2 commits intomasterfrom
AndrewChubatiuk wants to merge 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:30">
P1: Rule violated: **Changelog Review Agent**
Changelog entry lacks the required before/after user-visible explanation. The rule’s “User-centric explanation” clause requires stating prior behavior and what changed for users; this line only says “support conversion” without explaining the previous missing behavior and the improvement.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
vrutkovs
reviewed
Feb 5, 2026
…rsion to vmalertmanagerconfig spec.timeIntervals
2d59d25 to
3224c32
Compare
Contributor
Author
|
@vrutkovs thanks for review |
Signed-off-by: Andrii Chubatiuk <achubatiuk@victoriametrics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1783
Summary by cubic
Adds conversion for AlertmanagerConfig muteTimeIntervals to VMAlertmanagerConfig timeIntervals so mute windows are preserved and applied correctly.
Written for commit 8f6f588. Summary will update on new commits.