Skip to content

convert: support prom alertmanagerconfig spec.muteTimeIntervals conve…#1784

Open
AndrewChubatiuk wants to merge 2 commits intomasterfrom
convert-mute-time-intervals
Open

convert: support prom alertmanagerconfig spec.muteTimeIntervals conve…#1784
AndrewChubatiuk wants to merge 2 commits intomasterfrom
convert-mute-time-intervals

Conversation

@AndrewChubatiuk
Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk commented Feb 4, 2026

fixes #1783


Summary by cubic

Adds conversion for AlertmanagerConfig muteTimeIntervals to VMAlertmanagerConfig timeIntervals so mute windows are preserved and applied correctly.

  • Bug Fixes
    • Convert names, times, weekdays, daysOfMonth, months, and years from Prometheus MuteTimeIntervals into VM TimeIntervals.
    • Extend tests to validate the conversion and add a changelog entry.

Written for commit 8f6f588. Summary will update on new commits.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:30">
P1: Rule violated: **Changelog Review Agent**

Changelog entry lacks the required before/after user-visible explanation. The rule’s “User-centric explanation” clause requires stating prior behavior and what changed for users; this line only says “support conversion” without explaining the previous missing behavior and the improvement.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

…rsion to vmalertmanagerconfig spec.timeIntervals
@AndrewChubatiuk AndrewChubatiuk force-pushed the convert-mute-time-intervals branch from 2d59d25 to 3224c32 Compare February 5, 2026 11:51
@AndrewChubatiuk
Copy link
Contributor Author

@vrutkovs thanks for review
addressed you comments

Signed-off-by: Andrii Chubatiuk <achubatiuk@victoriametrics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to convert time_interval settings from Prometheus AlertmanagerConfig

2 participants