reconcile: removed nested retry logic, which led to parallel pods rollout

[AndrewChubatiuk]

fixes #1693

---

Summary by cubic

Fixes swallowed reconcile timeouts that caused parallel pod rollouts. Pods now roll out sequentially for StatefulSet, Deployment, and DaemonSet. Addresses #1693.

• Bug Fixes
  • Moved readiness waits outside retryOnConflict so errors are surfaced and handled.
  • Deployment/DaemonSet: perform create/update, then wait for readiness.
  • StatefulSet: simplified update flow, correct recreate detection, rolling update honors MaxUnavailable; PVC resizing runs after update.

^{Written for commit 7166e39. Summary will update on new commits.}

[cubic-dev-ai]

2 issues found across 4 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="internal/controller/operator/factory/reconcile/deploy.go">

<violation number="1" location="internal/controller/operator/factory/reconcile/deploy.go:94">
P2: The new unconditional wait triggers a second readiness poll when the no-change branch already waits inside retryOnConflict, causing redundant wait/poll cycles. Consider returning nil in the no-change branch and rely on the outer wait, or track a flag to avoid double waiting.</violation>
</file>

<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:32">
P3: Use the correct Kubernetes kind capitalization (`DaemonSet`) in the changelog entry to avoid confusion and match official naming.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

@cubic-dev-ai review this PR

@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete.

[AndrewChubatiuk]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

2 issues found across 4 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="internal/controller/operator/factory/reconcile/statefulset.go">

<violation number="1" location="internal/controller/operator/factory/reconcile/statefulset.go:163">
P0: Nil pointer dereference: `cr.UpdateBehavior` is accessed without a nil check. When `UpdateBehavior` is nil (as in callers like `vmalertmanager`), this will panic. The old code guarded this with `if cr.UpdateBehavior != nil`.</violation>
</file>

<file name="docs/CHANGELOG.md">

<violation number="1" location="docs/CHANGELOG.md:32">
P2: Rule violated: **Changelog Review Agent**

Changelog entry includes internal implementation details (“timeout errors…during reconcile were just swallowed”), which violates the rule’s requirement to avoid implementation details in user-facing explanations. Rewrite to describe only the user-visible rollout behavior change.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 4 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="internal/controller/operator/factory/reconcile/statefulset.go">

<violation number="1" location="internal/controller/operator/factory/reconcile/statefulset.go:161">
P1: Guard `cr.UpdateBehavior` before dereferencing it in the OnDelete update strategy; it is optional and the current code will panic when it is nil.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

No issues found across 4 files

[AndrewChubatiuk]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

1 issue found across 6 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="internal/controller/operator/factory/reconcile/statefulset_pvc_expand.go">

<violation number="1" location="internal/controller/operator/factory/reconcile/statefulset_pvc_expand.go:29">
P3: The updated comment is now inaccurate: this function no longer performs the recreate; it only reports whether a recreate (and pod recreation) is required. Clarify the comment to match the new behavior.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[AndrewChubatiuk]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 7 files