Open
Conversation
vineet-suri
suggested changes
Jul 15, 2022
vineet-suri
left a comment
vineet-suri
left a comment
There was a problem hiding this comment.
Try to add comments to the functions wherever applicable
client/src/app.ts
Outdated
| } | ||
|
|
||
| export class User<T extends Array<object>,U extends Array<Array<string>>> implements UserAction{ | ||
| APIData:Array<object> = []; |
Owner
Author
There was a problem hiding this comment.
all variables are changed into camel case
client/src/app.ts
Outdated
| let val = descriptor.value | ||
| descriptor.value = function(... args:any[]){ | ||
| let arr:Array<string> = []; | ||
| for(let j=0;j<7;j++){ |
There was a problem hiding this comment.
try to use descriptive constants instead of numbers. That makes code more readable.
Owner
Author
There was a problem hiding this comment.
changed the numbers into more readable format
client/src/models/model.ts
Outdated
Comment on lines
+10
to
+12
| addUser(refer:any):void, | ||
| selectedRowEdit(refer:any):void, | ||
| selectedRowDelete(i:any):void |
There was a problem hiding this comment.
why using any type?
we should define proper types as far as possible.
Owner
Author
There was a problem hiding this comment.
changed the any type with proper type
client/src/tabular.ts
Outdated
| } | ||
| let cell = row.insertCell(-1) | ||
| let inputField = document.createElement('input') as HTMLInputElement; | ||
| if(column==="Phone Number"){ |
Owner
Author
There was a problem hiding this comment.
changed the column name into enum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.