Use Java 17 mapping when generating docs with Scala 3.8+ with doc#4180
Open
Gedochao wants to merge 1 commit intoVirtusLab:mainfrom
Open
Use Java 17 mapping when generating docs with Scala 3.8+ with doc#4180Gedochao wants to merge 1 commit intoVirtusLab:mainfrom
doc#4180Gedochao wants to merge 1 commit intoVirtusLab:mainfrom
Conversation
Gedochao
force-pushed
the
maintenance/use-java-17-for-scala-3.8-plus
branch
from
d450f04 to
c5af806
Compare
hamzaremmal
reviewed
Mar 12, 2026
Gedochao
force-pushed
the
maintenance/use-java-17-for-scala-3.8-plus
branch
from
c5af806 to
2b0a62d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scala 3.8 uses Java 17, adjusted the
doccommand passed external mappings.Checklist
scala-cli fmt .)scalafix(./mill -i __.fix)./mill -i 'generate-reference-doc[]'.run)How much have your relied on LLM-based tools in this contribution?
extensively, Cursor + Claude
How was the solution tested?
Added a simple unit test.
Verified the mappings work, otherwise (an integration test feels overkill, but let me know if I should add smth anyway).
Additional notes
Kudos to @hamzaremmal for spotting this