Restore BSP base directory to the original workspace regardless of permissions/ownership#4273
Draft
Gedochao wants to merge 2 commits into
Draft
Restore BSP base directory to the original workspace regardless of permissions/ownership#4273Gedochao wants to merge 2 commits into
Gedochao wants to merge 2 commits into
Conversation
…rmissions/ownership
…s when a virtual directory is used by BSP
Gedochao
force-pushed
the
fix/wonky-base-directory
branch
from
dd61325 to
6060cd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the owner of the workspace directory changes or permissions don't match,
.scala-builddirectory gets saved in a temporary directory.This in turn breaks BSP reporting the temporary directory in
workspaceBuildTargetendpoints.The ownership change happens when adding files in containerised IntelliJ setups, which makes supporting Scala CLI there tricky.
Checklist
scala-cli fmt .)scalafix(./mill -i __.fix)How much have your relied on LLM-based tools in this contribution?
Extensively, Cursor + Claude
How was the solution tested?
Added new integration tests