Skip to content

Prevent temporarily changed .gitignore file from being committed and pushed#757

Open
wraschke wants to merge 3 commits intovNextfrom
fix-create-new-release-script
Open

Prevent temporarily changed .gitignore file from being committed and pushed#757
wraschke wants to merge 3 commits intovNextfrom
fix-create-new-release-script

Conversation

@wraschke
Copy link
Copy Markdown
Member

@wraschke wraschke commented May 6, 2026

Changes to this repo's .gitignore file are being unintentionally committed and pushed.

The create-new-release.sh script changes this file to comment out line ga/*/*/resources/* in order so that the newly created release's resources subdir can be commited and pushed. But, the ignore file has that entry in there so that no zip files that might be placed there in someone's local dir are pushed to the repository.

Recall that the dependency WL image zip is in that subdir because build scripts assume that location.

@wraschke
Copy link
Copy Markdown
Member Author

wraschke commented May 6, 2026

I tested the pre-commit hook change locally. When I make a test change and commit of .gitignore, this is my output:

Prevent .gitignore from getting committed................................Failed
- hook id: no-gitignore-commit
- exit code: 1

.gitignore file commit detected

.gitignore

I do acknowledge that the .gitignore file might need another sort of change that requires a commit--one that is not the commenting out of that line. But, this pattern has been in place for so long and so far, I have not seen any recent changes to the ignore file.

If developer has a legitimate reason to change and commit the ignore file, s/he will need to be intentional about that and modify the pre-commit config to accommodate.

@wraschke wraschke requested review from gkertasef and leochr May 6, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant