Prevent temporarily changed .gitignore file from being committed and pushed#757
Open
Prevent temporarily changed .gitignore file from being committed and pushed#757
Conversation
Member
Author
|
I tested the pre-commit hook change locally. When I make a test change and commit of I do acknowledge that the If developer has a legitimate reason to change and commit the ignore file, s/he will need to be intentional about that and modify the pre-commit config to accommodate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to this repo's
.gitignorefile are being unintentionally committed and pushed.The create-new-release.sh script changes this file to comment out line
ga/*/*/resources/*in order so that the newly created release'sresourcessubdir can be commited and pushed. But, the ignore file has that entry in there so that no zip files that might be placed there in someone's local dir are pushed to the repository.Recall that the dependency WL image zip is in that subdir because build scripts assume that location.