feat: add grid view to assistant selector, toggle for hiding the title in bottom sheet#82
feat: add grid view to assistant selector, toggle for hiding the title in bottom sheet#82WSTxda merged 3 commits intoWSTxda:mainfrom
Conversation
|
sorry for 2nd commit, actually my first Pr |
|
Hi, thanks for contribution! I noticed a few things that could be improved. 1. The alignment of the tip card and scrollbar needs to be adjusted. 2. The grid view needs to be customizable or adaptive to provide proper support at high or low DPI settings. Low DPI:In this case, you can reduce the grid size to 2x. Landscape mode:In this case, you can Increase the width to 4x and keep 3x for low DPI. These changes are simple and can be made using only declarative XML. However, my suggestion is to allow the user to customize the grid size. Another suggestion is to make the assistants compact pills to reduce scrolling and improve landscape navigation. (not mandatory). |
…verridable column settings
|
Hi! Thanks for reaching out! Implemented a grid column count that adapts automatically based on screen density and orientation — computed at runtime using densityDpi rather than resource qualifiers (which Android resolves incorrectly for intermediate densities). Portrait defaults to 3 columns (2 on low-density screens), landscape to 4 (3 on low-density). Users can override both orientations independently via dedicated settings entries that appear when grid view is enabled. P.S. and quick fixes based by your suggestions and my mistakes |
Some ideas to explore soon.1 - We could unify the list view and grid view into a single manager menu, where "1" row equals the list view. 2 - I think the automatic grid row control could be completely removed, since we already have the option to set the grid in both orientations.
3 - Soon I'll add another option to customize component visibility, called "Manage Components" or something like that. The title and search bar can be moved into it. @dmitthedazed The commit is great for this and shouldn't require many changes. We can also merge this behavior into a single ViewHolder. Rows1 → list view |
|
I can't quite get your idea for the 1st idea, maybe you have some sketch for this one. However i have some other suggestions, might open a PR for it if i feel like it
|
The reorganization of the settings should allow this. I can make a complete preview of the selector dialog if I have a dedicated fragment for these preferences.
The idea behind the pinned assistants is that they remain permanently at the top of the list, even above the recent assistants ones. In addition, we have an option to customize the visibility of the assistants. Idk what the real use of this is.
If it's a text or voice chat assistant, it can be included. |
|
@dmitthedazed This should be the expected interface. |






just thought it was be nice and minimal to add a grid view, and to add a toggle to hide the title from bottom sheet. tried my best. tysm for your work anyway!