fix(types): make getEntries return unknown instead of generic T#266
Open
Sushil-19 wants to merge 1 commit intoWalletConnect:masterfrom
Open
fix(types): make getEntries return unknown instead of generic T#266Sushil-19 wants to merge 1 commit intoWalletConnect:masterfrom
Sushil-19 wants to merge 1 commit intoWalletConnect:masterfrom
Conversation
|
All contributors have signed the CTA ✍️ ✅ |
Author
|
I have read the CTA Document and I hereby sign the CTA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the incorrect typing of
getEntries().The previous signature exposed a generic
<T>, which implied that all returned entries share the same type. Since the storage can contain heterogeneous values (sessions, pairings, metadata, etc.), this assumption is not guaranteed and therefore unsound.Background
getEntries<T>()suggests that consumers can safely expect every stored value to conform toT. However, the underlying storage layer is type-agnostic and may return different object shapes depending on what was persisted.This mismatch between the type contract and runtime behavior can lead to incorrect assumptions or unsafe downstream usage.
Changes
getEntriesPromise<[string, unknown][]>as [string, T]) in implementationsScope
This PR strictly corrects the type definition to reflect actual storage behavior.
No changes were made to persistence logic, session handling, or storage flow.
All existing behavior remains unchanged.