Merged
Conversation
github-actions
bot
added
P-cli
Contributor
Author
|
Thank you for the review! While this is a small tweak, I want to make sure we first have consensus on the precedent (specifically changing to |
Contributor
|
Ah the variant with the |
ricochet
force-pushed
the
other-for-non-exhaustive
branch
from
a1ddd87 to
15d8767
Compare
ricochet
force-pushed
the
other-for-non-exhaustive
branch
from
15d8767 to
ad4ec7c
Compare
lukewagner
approved these changes
Mar 12, 2026
Member
lukewagner
left a comment
lukewagner
left a comment
There was a problem hiding this comment.
lgtm2 (as the pattern we're using elsewhere)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #892