Fix missing implicitTrap for ArrayRMW and ArrayCmpxchg#8328
Open
sumleo wants to merge 1 commit intoWebAssembly:mainfrom
Open
Fix missing implicitTrap for ArrayRMW and ArrayCmpxchg#8328sumleo wants to merge 1 commit intoWebAssembly:mainfrom
sumleo wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
ArrayRMW and ArrayCmpxchg only set implicitTrap when the array reference is nullable, but they should set it unconditionally because an out-of-bounds index also traps. All other indexed array operations (ArrayGet, ArraySet, ArrayCopy, ArrayFill, ArrayInitData, ArrayInitElem) correctly set implicitTrap unconditionally for OOB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visitArrayRMWandvisitArrayCmpxchginEffectAnalyzeronly setimplicitTrapwhen the array reference is nullable, missing the out-of-bounds index case.ArrayGet,ArraySet,ArrayCopy,ArrayFill,ArrayInitData,ArrayInitElem) correctly setimplicitTrapunconditionally.implicitTrap = trueunconditionally, matching the pattern of other array operations.Test plan
ArrayRMW/ArrayCmpxchgwith the existing pattern used by all other array operations.