Fix grammar for names and add some more tests#620
Merged
lukewagner merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
esoterra
approved these changes
Mar 9, 2026
alexcrichton
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As caught in #619, #592 accidentally allowed empty non-first
words while refactoring the grammar. This PR fixes that and also updatesnamespacewhich was also accidentally regressed by #592. The PR also adds tests which all currently pass, so this is just a spec fix, not impl change.