refactor: make message property setters fallible#29
Open
rvolosatovs wants to merge 1 commit intoWebAssembly:mainfrom
Open
refactor: make message property setters fallible#29rvolosatovs wants to merge 1 commit intoWebAssembly:mainfrom
rvolosatovs wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
Support for `content-type` and metadata/headers across different message queues and services is not uniform. For example, RabbitMQ has built-in support for `content-type`, but NATS.io does not. Make setters of these properties on the message resource fallible to account for this difference. Note, that this is only a partial solution to the bigger issue: What's the correct behavior on the host's part when content-type and/or metadata is set in the guest message, but not supported by the underlying implementation? Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
This was referenced Dec 5, 2024
Collaborator
|
Could you please take a look at this PR, @danbugs ? |
danbugs
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for
content-typeand metadata/headers across different message queues and services is not uniform. For example, RabbitMQ has built-in support forcontent-type, but NATS.io does not.Make setters of these properties on the message resource fallible to account for this difference.
Note, that this is only a partial solution to the bigger issue: What's the correct behavior on the host's part when content-type and/or metadata is set in the guest message, but not supported by the underlying implementation? (#30)