Skip to content

[WPE] Extend PROJECT_VERSINO_MICRO with external suffix#1667

Draft
asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
asurdej-comcast:wpe_webkit_version
Draft

[WPE] Extend PROJECT_VERSINO_MICRO with external suffix#1667
asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
asurdej-comcast:wpe_webkit_version

Conversation

@asurdej-comcast
Copy link
Copy Markdown

@asurdej-comcast asurdej-comcast commented May 6, 2026

Webkit exposes APIs to query currently running version:

#define WEBKIT_MAJOR_VERSION (@PROJECT_VERSION_MAJOR@)
#define WEBKIT_MINOR_VERSION (@PROJECT_VERSION_MINOR@)
#define WEBKIT_MICRO_VERSION (@PROJECT_VERSION_MICRO@)

#define WEBKIT_CHECK_VERSION(major, minor, micro) \
    (WEBKIT_MAJOR_VERSION > (major) || \
    (WEBKIT_MAJOR_VERSION == (major) && WEBKIT_MINOR_VERSION > (minor)) || \
    (WEBKIT_MAJOR_VERSION == (major) && WEBKIT_MINOR_VERSION == (minor) && \
     WEBKIT_MICRO_VERSION >= (micro)))

WEBKIT_API guint
webkit_get_major_version (void);

WEBKIT_API guint
webkit_get_minor_version (void);

WEBKIT_API guint
webkit_get_micro_version (void);

That doesn't change frequently because it corresponds to upstream webkit relase version I believe.

The problem is that WPE webkit constantly receives new updates, new commits, new APIs. Our integration code is separated from webkit and delivered externally to the device so it doesn't stick to any particular webkit version. It loads the library in runtime and we need some way to tell what set of APIs is available in this particular version.
Using webkit versioning API is fine to distinguish between webkit 2.38 and 2.46 but it doesn't tell much on 2.46 patch level.

My proposal here is to extend current versioning with one more number that will be part of MICRO version. We can manually bump it up every "internal release" so we can check exact version in runtime while still keeping original upstream versioning intact.

67826a1

Build-Tests Layout-Tests
✅ 🛠 wpe-246-amd64-build ✅ 🧪 wpe-246-amd64-layout
✅ 🛠 wpe-246-arm32-build ✅ 🧪 wpe-246-arm32-layout

@magomez
Copy link
Copy Markdown

magomez commented May 6, 2026

@asurdej-comcast your proposal sounds good. It can also be 2.46.7.1 or even increase the micro version whenever we want. Whatever works best for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants