[WPE] Extend PROJECT_VERSINO_MICRO with external suffix#1667
Draft
asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
Draft
[WPE] Extend PROJECT_VERSINO_MICRO with external suffix#1667asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
asurdej-comcast wants to merge 1 commit intoWebPlatformForEmbedded:wpe-2.46from
Conversation
magomez
approved these changes
May 6, 2026
|
@asurdej-comcast your proposal sounds good. It can also be 2.46.7.1 or even increase the micro version whenever we want. Whatever works best for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webkit exposes APIs to query currently running version:
That doesn't change frequently because it corresponds to upstream webkit relase version I believe.
The problem is that WPE webkit constantly receives new updates, new commits, new APIs. Our integration code is separated from webkit and delivered externally to the device so it doesn't stick to any particular webkit version. It loads the library in runtime and we need some way to tell what set of APIs is available in this particular version.
Using webkit versioning API is fine to distinguish between webkit 2.38 and 2.46 but it doesn't tell much on 2.46 patch level.
My proposal here is to extend current versioning with one more number that will be part of MICRO version. We can manually bump it up every "internal release" so we can check exact version in runtime while still keeping original upstream versioning intact.
67826a1