-
Notifications
You must be signed in to change notification settings - Fork 0
Release 2.0.0 #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 2.0.0 #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`InstantInterval.size` could overflow and return `Infinity`. To fix this, coerce values into a range which always allows a valid `size` to be returned. `IntervalTypeOperations.unsafeValueAt` is added to test this, and because it will be needed to implement future interval operations.
Apparently the Gradle config for native targets changed in Kotlin 2.1.0 as builds were now failing. This fixes this, and adds more exhaustive targets (though still not all possible targets).
Something changed in the Kotlin Gradle Plugin 2.1.0 which causes it to use an outdated "version" (before it is modified to include a "-SNAPSHOT" suffix) when looking for ".klib" files. This causes a FileNotFound exception during publications.
In addition: - renamed one `IntervalTest` which incorrectly claimed to test an "empty" interval. - made `emptyIntervalUnion` public; no real need to keep this internal.
Moved to a base class to both be used as part of `IntervalTest`, but also for future tests independent of specific Interval types.
This allows implementations which lead to less loss of precision.
And, fix infinity interval sizes for float/double intervals by reducing the min/max of interval type operations, which in turn allows reintroducing infinity as min/max values for the basic type operations.
Since `IntervalTypeOperations` has changed, this is now a breaking API version.
Closes #66
When upgrading to Kotlin 2.1.0, the current Gradle configuration caused problems (#62), likely due to order of execution of Gradle commands. Therefore, configuring a snapshot publication is now done using a command line parameter.
The `buildDirectory` was incorrect when calling `publish`. Also removed a now obsolete `OptIn` attribute.
Test prerequisites of `IntervalTest` had to be updated to facilitate testing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions to
IntervalUnionandInterval:shift()offsets an interval by a specified amount (also asshlandshroperators).Additions to
Interval:getValueAt()retrieves a value at a given percentage within (0.0–1.0) or outside (< 0.0, > 1.0) of the interval.Bugfixes:
EmptyIntervalUnion.containsfailedAdditions to type operations used by interval, and thus a breaking change for extending libraries:
IntervalTypeOperations.unsafeValueAt()IntervalTypeOperations.unsafeShift()TypeOperations.fromDouble()andtoDouble()Dependency updates: