Validate XPort v5 variable name length (max 8 chars)#360
Open
andreasnoack wants to merge 1 commit intoWizardMac:devfrom
Open
Validate XPort v5 variable name length (max 8 chars)#360andreasnoack wants to merge 1 commit intoWizardMac:devfrom
andreasnoack wants to merge 1 commit intoWizardMac:devfrom
Conversation
The XPort writer was using sas_validate_variable which allows 32-char names, but v5 XPort only supports 8-char names (nname[8]). Names longer than 8 chars were silently truncated. Now v5 returns READSTAT_ERROR_NAME_IS_TOO_LONG instead.
Author
|
I believe the Windows failure is unrelated to the changes here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XPort writer was using sas_validate_variable which allows 32-char names, but v5 XPort only supports 8-char names (nname[8]). Names longer than 8 chars were silently truncated. Now v5 returns READSTAT_ERROR_NAME_IS_TOO_LONG instead.
(Commit created with Claude Code)