Conversation
| }, | ||
| { | ||
| "nameEN": "Ania Nakayama", | ||
| "nameJA": "中山アンナ", |
There was a problem hiding this comment.
This is from her LinkedIn page
| { | ||
| "nameEN": "Krizza Bullecer", | ||
| "nameJA": "ブレサー クリザ", | ||
| "nameJA": "ブレサー・クリザ", |
There was a problem hiding this comment.
The whitespace was an invisible unicode character so let's use an interpunct
There was a problem hiding this comment.
Pull request overview
Updates the site’s Leadership Team listing and associated checks to reflect current roles and ownership, including removing a departing member from default code review ownership.
Changes:
- Updated leadership team entries (names/titles, including legacy roles) and Japanese name formatting in
team.json. - Updated Playwright E2E expectations for the Team page ordering and link checks.
- Removed
@ann-kilzerfrom the global.github/CODEOWNERSentry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/routes/Team/team.json |
Updates team member records (roles/order) and one Japanese name punctuation change. |
e2e/team.spec.ts |
Aligns E2E assertions with the updated team order/titles and link ordering. |
.github/CODEOWNERS |
Removes @ann-kilzer from global ownership. |
| // verify link | ||
| const links = await page.getByLabel('link-wrapper').all() | ||
| expect(links).toHaveLength(2) | ||
| const annLink = links[0] | ||
| const rossLink = links[1] | ||
| const rossLink = links[0] | ||
| const annLink = links[1] | ||
| await expect(annLink).toBeVisible() |
There was a problem hiding this comment.
The link assertions rely on links[0]/links[1] DOM order after getByLabel('link-wrapper').all(). This is a bit brittle: adding another URL’d team member or reordering team.json will break the test even if behavior is correct. Consider scoping the link lookup to the specific member card (find the card by member name, then assert the wrapped link’s href/target).
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
There was a problem hiding this comment.
Yeah that's valid... this is brittle
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@ann-kilzer I've opened a new pull request, #296, to work on those changes. Once the pull request is ready, I'll request review from you. |
Resolves #295
What changed 🧐
Encountered some technical debt around eslint while working on this. Please see #293
How did you test it? 🧪
E2E tests and visual inspection of the Team page