Use released compile-extension package for WASM builds#402
Draft
Use released compile-extension package for WASM builds#402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
WordPress/wordpress-playgroundsparse checkouts and shared base-image artifact job from the WASM workflows.@php-wasm/compile-extension@3.1.28package, including--prepare-imagefor the Rust builder base image.@php-wasm/node@3.1.28and@php-wasm/universal@3.1.28packages.Why
@php-wasm/compile-extensionnow lazily fetches the Docker assets it needs from its matching Playground release, so downstream CI no longer needs to shallow or sparse checkoutwordpress-playgroundjust to build this extension.Validation
bash -n packages/php-ext-wp-mysql-parser/wasm-spike/build-in-docker-rust.shnode --experimental-wasm-jspi --check packages/php-ext-wp-mysql-parser/wasm-spike/run-spike.mjsgit diff --checkyaml@2@php-wasm/compile-extension,@php-wasm/node, and@php-wasm/universalall publish3.1.28I could not run the full Docker build locally because Docker is not installed in this environment; the PR workflow should cover that path.