-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Media: Use Document-Isolation-Policy for cross-origin isolation #11098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Changes from all commits
52839e5
f4bfea0
064ee21
aa34c2d
c936dcc
602018a
291c608
05dcc36
0bdef9d
7ff16b3
0f03b4b
8f838ff
d501fb9
1c61294
fa9c07f
7b11b34
86107f1
619cb05
a022152
513471f
bfb8a9b
23ee73a
41102e0
acece5a
049f357
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Tests for cross-origin isolation functions. | ||
| * | ||
| * @group media | ||
| * @covers ::wp_set_up_cross_origin_isolation | ||
| * @covers ::wp_start_cross_origin_isolation_output_buffer | ||
| */ | ||
| class Tests_Media_wpCrossOriginIsolation extends WP_UnitTestCase { | ||
|
|
||
| /** | ||
| * Original HTTP_USER_AGENT value. | ||
| * | ||
| * @var string|null | ||
| */ | ||
| private $original_user_agent; | ||
|
|
||
| public function set_up() { | ||
| parent::set_up(); | ||
| $this->original_user_agent = isset( $_SERVER['HTTP_USER_AGENT'] ) ? $_SERVER['HTTP_USER_AGENT'] : null; | ||
| } | ||
|
|
||
| public function tear_down() { | ||
| if ( null === $this->original_user_agent ) { | ||
| unset( $_SERVER['HTTP_USER_AGENT'] ); | ||
| } else { | ||
| $_SERVER['HTTP_USER_AGENT'] = $this->original_user_agent; | ||
| } | ||
|
|
||
| // Clean up any output buffers started during tests. | ||
| while ( ob_get_level() > 1 ) { | ||
| ob_end_clean(); | ||
| } | ||
|
|
||
| remove_all_filters( 'wp_client_side_media_processing_enabled' ); | ||
| parent::tear_down(); | ||
| } | ||
|
|
||
| public function test_returns_early_when_client_side_processing_disabled() { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will add |
||
| add_filter( 'wp_client_side_media_processing_enabled', '__return_false' ); | ||
|
|
||
| // Should not error or start an output buffer. | ||
| $level_before = ob_get_level(); | ||
| wp_set_up_cross_origin_isolation(); | ||
| $level_after = ob_get_level(); | ||
|
|
||
| $this->assertSame( $level_before, $level_after ); | ||
| } | ||
|
|
||
| public function test_returns_early_when_no_screen() { | ||
| // No screen is set, so it should return early. | ||
| $level_before = ob_get_level(); | ||
| wp_set_up_cross_origin_isolation(); | ||
| $level_after = ob_get_level(); | ||
|
|
||
| $this->assertSame( $level_before, $level_after ); | ||
| } | ||
|
|
||
| /** | ||
| * @runInSeparateProcess | ||
| * @preserveGlobalState disabled | ||
| */ | ||
| public function test_starts_output_buffer_for_chrome_137() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36'; | ||
|
|
||
| $level_before = ob_get_level(); | ||
| wp_start_cross_origin_isolation_output_buffer(); | ||
| $level_after = ob_get_level(); | ||
|
|
||
| $this->assertSame( $level_before + 1, $level_after, 'Output buffer should be started for Chrome 137.' ); | ||
|
|
||
| ob_end_clean(); | ||
| } | ||
|
|
||
| public function test_does_not_start_output_buffer_for_chrome_136() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36'; | ||
|
|
||
| $level_before = ob_get_level(); | ||
| wp_start_cross_origin_isolation_output_buffer(); | ||
| $level_after = ob_get_level(); | ||
|
|
||
| $this->assertSame( $level_before, $level_after, 'Output buffer should not be started for Chrome < 137.' ); | ||
| } | ||
|
|
||
| public function test_does_not_start_output_buffer_for_firefox() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; rv:128.0) Gecko/20100101 Firefox/128.0'; | ||
|
|
||
| $level_before = ob_get_level(); | ||
| wp_start_cross_origin_isolation_output_buffer(); | ||
| $level_after = ob_get_level(); | ||
|
|
||
| $this->assertSame( $level_before, $level_after, 'Output buffer should not be started for Firefox.' ); | ||
| } | ||
|
|
||
| public function test_does_not_start_output_buffer_for_safari() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 14_5) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Safari/605.1.15'; | ||
|
|
||
| $level_before = ob_get_level(); | ||
| wp_start_cross_origin_isolation_output_buffer(); | ||
| $level_after = ob_get_level(); | ||
|
|
||
| $this->assertSame( $level_before, $level_after, 'Output buffer should not be started for Safari.' ); | ||
| } | ||
|
|
||
| /** | ||
| * @runInSeparateProcess | ||
| * @preserveGlobalState disabled | ||
|
Comment on lines
+107
to
+108
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we add comment why we need separate process? |
||
| */ | ||
| public function test_output_buffer_adds_crossorigin_attributes() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36'; | ||
|
|
||
| // Start an outer buffer to capture the callback-processed output. | ||
| ob_start(); | ||
|
|
||
| wp_start_cross_origin_isolation_output_buffer(); | ||
| echo '<img src="https://external.example.com/image.jpg" />'; | ||
|
|
||
| // Flush the inner buffer to trigger the callback, sending processed output to the outer buffer. | ||
| ob_end_flush(); | ||
| $output = ob_get_clean(); | ||
|
|
||
| $this->assertStringContainsString( 'crossorigin="anonymous"', $output ); | ||
| } | ||
| } | ||
adamsilverstein marked this conversation as resolved.
Show resolved
Hide resolved
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Tests for the `wp_get_chromium_major_version()` function. | ||
| * | ||
| * @group media | ||
| * @covers ::wp_get_chromium_major_version | ||
| */ | ||
| class Tests_Media_wpGetChromiumMajorVersion extends WP_UnitTestCase { | ||
|
|
||
| /** | ||
| * Original HTTP_USER_AGENT value. | ||
| * | ||
| * @var string|null | ||
| */ | ||
| private $original_user_agent; | ||
|
|
||
| public function set_up() { | ||
| parent::set_up(); | ||
| $this->original_user_agent = isset( $_SERVER['HTTP_USER_AGENT'] ) ? $_SERVER['HTTP_USER_AGENT'] : null; | ||
| } | ||
|
|
||
| public function tear_down() { | ||
| if ( null === $this->original_user_agent ) { | ||
| unset( $_SERVER['HTTP_USER_AGENT'] ); | ||
| } else { | ||
| $_SERVER['HTTP_USER_AGENT'] = $this->original_user_agent; | ||
| } | ||
| parent::tear_down(); | ||
| } | ||
|
|
||
| public function test_returns_null_when_no_user_agent() { | ||
| unset( $_SERVER['HTTP_USER_AGENT'] ); | ||
| $this->assertNull( wp_get_chromium_major_version() ); | ||
| } | ||
|
|
||
| public function test_returns_null_for_empty_user_agent() { | ||
| $_SERVER['HTTP_USER_AGENT'] = ''; | ||
| $this->assertNull( wp_get_chromium_major_version() ); | ||
| } | ||
|
|
||
| public function test_returns_null_for_firefox() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; rv:128.0) Gecko/20100101 Firefox/128.0'; | ||
| $this->assertNull( wp_get_chromium_major_version() ); | ||
| } | ||
|
|
||
| public function test_returns_null_for_safari() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 14_5) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Safari/605.1.15'; | ||
| $this->assertNull( wp_get_chromium_major_version() ); | ||
| } | ||
|
|
||
| public function test_returns_version_for_chrome() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36'; | ||
| $this->assertSame( 137, wp_get_chromium_major_version() ); | ||
| } | ||
|
|
||
| public function test_returns_version_for_edge() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36 Edg/137.0.0.0'; | ||
| $this->assertSame( 137, wp_get_chromium_major_version() ); | ||
| } | ||
|
|
||
| public function test_returns_version_for_opera() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36 OPR/122.0.0.0'; | ||
| $this->assertSame( 136, wp_get_chromium_major_version() ); | ||
| } | ||
|
|
||
| public function test_returns_version_for_older_chrome() { | ||
| $_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.75 Safari/537.36'; | ||
| $this->assertSame( 100, wp_get_chromium_major_version() ); | ||
| } | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.