Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
52839e5
Media: Use Document-Isolation-Policy for COI
adamsilverstein Mar 1, 2026
f4bfea0
remove md file
adamsilverstein Mar 1, 2026
064ee21
Disable client-side media processing on non-DIP browsers
adamsilverstein Mar 1, 2026
aa34c2d
Add tests for cross-origin isolation functions
adamsilverstein Mar 1, 2026
c936dcc
Update for DIP-only approach
adamsilverstein Mar 1, 2026
602018a
Fix header tests to run in separate processes
adamsilverstein Mar 1, 2026
291c608
Add __documentIsolationPolicy JS flag
adamsilverstein Mar 1, 2026
05dcc36
Tests: Fix output buffer test to correctly capture callback-processed…
adamsilverstein Mar 1, 2026
0bdef9d
Remove wp_use_document_isolation_policy filter
adamsilverstein Mar 2, 2026
7ff16b3
Merge branch 'trunk' into backport-75991
adamsilverstein Mar 2, 2026
0f03b4b
Merge branch 'trunk' into backport-75991
adamsilverstein Mar 3, 2026
8f838ff
Merge branch 'trunk' into backport-75991
adamsilverstein Mar 3, 2026
d501fb9
Update src/wp-includes/media.php
adamsilverstein Mar 4, 2026
1c61294
Apply suggestions from code review
adamsilverstein Mar 4, 2026
fa9c07f
Merge branch 'trunk' into backport-75991
adamsilverstein Mar 4, 2026
7b11b34
Merge branch 'trunk' into backport-75991
adamsilverstein Mar 5, 2026
86107f1
Tests: Rename wpGetChromeMajorVersion test to wpGetChromiumMajorVersion.
adamsilverstein Mar 5, 2026
619cb05
Update src/wp-includes/media.php
adamsilverstein Mar 5, 2026
a022152
Media: Remove page builder skip logic from cross-origin isolation.
adamsilverstein Mar 5, 2026
513471f
Update src/wp-includes/media.php
adamsilverstein Mar 5, 2026
bfb8a9b
Tests: Remove obsolete page builder skip tests from cross-origin isol…
adamsilverstein Mar 5, 2026
23ee73a
Tests: Merge cross-origin isolation test files into one.
adamsilverstein Mar 5, 2026
41102e0
Merge branch 'trunk' into backport-75991
adamsilverstein Mar 5, 2026
acece5a
Merge branch 'trunk' into backport-75991
adamsilverstein Mar 5, 2026
049f357
Merge remote-tracking branch 'origin/trunk' into backport-75991
adamsilverstein Mar 5, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 35 additions & 15 deletions src/wp-includes/media.php
Original file line number Diff line number Diff line change
Expand Up @@ -6393,6 +6393,12 @@ function wp_set_client_side_media_processing_flag(): void {

wp_add_inline_script( 'wp-block-editor', 'window.__clientSideMediaProcessing = true', 'before' );

$chromium_version = wp_get_chromium_major_version();

if ( null !== $chromium_version && $chromium_version >= 137 ) {
wp_add_inline_script( 'wp-block-editor', 'window.__documentIsolationPolicy = true;', 'before' );
}

/*
* Register the @wordpress/vips/worker script module as a dynamic dependency
* of the wp-upload-media classic script. This ensures it is included in the
Expand All @@ -6405,15 +6411,33 @@ function wp_set_client_side_media_processing_flag(): void {
);
}

/**
* Returns the major Chrome/Chromium version from the current request's User-Agent.
*
* Matches all Chromium-based browsers (Chrome, Edge, Opera, Brave).
*
* @since 7.0.0
*
* @return int|null The major Chrome version, or null if not a Chromium browser.
*/
function wp_get_chromium_major_version(): ?int {
if ( empty( $_SERVER['HTTP_USER_AGENT'] ) ) {
return null;
}
if ( preg_match( '#Chrome/(\d+)#', $_SERVER['HTTP_USER_AGENT'], $matches ) ) {
return (int) $matches[1];
}
return null;
}

/**
* Enables cross-origin isolation in the block editor.
*
* Required for enabling SharedArrayBuffer for WebAssembly-based
* media processing in the editor.
* media processing in the editor. Uses Document-Isolation-Policy
* on supported browsers (Chromium 137+).
*
* @since 7.0.0
*
* @link https://web.dev/coop-coep/
*/
function wp_set_up_cross_origin_isolation(): void {
if ( ! wp_is_client_side_media_processing_enabled() ) {
Expand All @@ -6439,26 +6463,22 @@ function wp_set_up_cross_origin_isolation(): void {
}

/**
* Starts an output buffer to send cross-origin isolation headers.
* Sends the Document-Isolation-Policy header for cross-origin isolation.
*
* Sends headers and uses an output buffer to add crossorigin="anonymous"
* attributes where needed.
* Uses an output buffer to add crossorigin="anonymous" where needed.
*
* @since 7.0.0
*
* @link https://web.dev/coop-coep/
*
* @global bool $is_safari
*/
function wp_start_cross_origin_isolation_output_buffer(): void {
global $is_safari;
$chromium_version = wp_get_chromium_major_version();

$coep = $is_safari ? 'require-corp' : 'credentialless';
if ( null === $chromium_version || $chromium_version < 137 ) {
return;
}

ob_start(
static function ( string $output ) use ( $coep ): string {
header( 'Cross-Origin-Opener-Policy: same-origin' );
header( "Cross-Origin-Embedder-Policy: $coep" );
static function ( string $output ): string {
header( 'Document-Isolation-Policy: isolate-and-credentialless' );

return wp_add_crossorigin_attributes( $output );
}
Expand Down
125 changes: 125 additions & 0 deletions tests/phpunit/tests/media/wpCrossOriginIsolation.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
<?php

/**
* Tests for cross-origin isolation functions.
*
* @group media
* @covers ::wp_set_up_cross_origin_isolation
* @covers ::wp_start_cross_origin_isolation_output_buffer
*/
class Tests_Media_wpCrossOriginIsolation extends WP_UnitTestCase {

/**
* Original HTTP_USER_AGENT value.
*
* @var string|null
*/
private $original_user_agent;

public function set_up() {
parent::set_up();
$this->original_user_agent = isset( $_SERVER['HTTP_USER_AGENT'] ) ? $_SERVER['HTTP_USER_AGENT'] : null;
}

public function tear_down() {
if ( null === $this->original_user_agent ) {
unset( $_SERVER['HTTP_USER_AGENT'] );
} else {
$_SERVER['HTTP_USER_AGENT'] = $this->original_user_agent;
}

// Clean up any output buffers started during tests.
while ( ob_get_level() > 1 ) {
ob_end_clean();
}

remove_all_filters( 'wp_client_side_media_processing_enabled' );
parent::tear_down();
}

public function test_returns_early_when_client_side_processing_disabled() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ticket annotation is missing in all unit tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add

add_filter( 'wp_client_side_media_processing_enabled', '__return_false' );

// Should not error or start an output buffer.
$level_before = ob_get_level();
wp_set_up_cross_origin_isolation();
$level_after = ob_get_level();

$this->assertSame( $level_before, $level_after );
}

public function test_returns_early_when_no_screen() {
// No screen is set, so it should return early.
$level_before = ob_get_level();
wp_set_up_cross_origin_isolation();
$level_after = ob_get_level();

$this->assertSame( $level_before, $level_after );
}

/**
* @runInSeparateProcess
* @preserveGlobalState disabled
*/
public function test_starts_output_buffer_for_chrome_137() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36';

$level_before = ob_get_level();
wp_start_cross_origin_isolation_output_buffer();
$level_after = ob_get_level();

$this->assertSame( $level_before + 1, $level_after, 'Output buffer should be started for Chrome 137.' );

ob_end_clean();
}

public function test_does_not_start_output_buffer_for_chrome_136() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36';

$level_before = ob_get_level();
wp_start_cross_origin_isolation_output_buffer();
$level_after = ob_get_level();

$this->assertSame( $level_before, $level_after, 'Output buffer should not be started for Chrome < 137.' );
}

public function test_does_not_start_output_buffer_for_firefox() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; rv:128.0) Gecko/20100101 Firefox/128.0';

$level_before = ob_get_level();
wp_start_cross_origin_isolation_output_buffer();
$level_after = ob_get_level();

$this->assertSame( $level_before, $level_after, 'Output buffer should not be started for Firefox.' );
}

public function test_does_not_start_output_buffer_for_safari() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 14_5) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Safari/605.1.15';

$level_before = ob_get_level();
wp_start_cross_origin_isolation_output_buffer();
$level_after = ob_get_level();

$this->assertSame( $level_before, $level_after, 'Output buffer should not be started for Safari.' );
}

/**
* @runInSeparateProcess
* @preserveGlobalState disabled
Comment on lines +107 to +108
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add comment why we need separate process?

*/
public function test_output_buffer_adds_crossorigin_attributes() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36';

// Start an outer buffer to capture the callback-processed output.
ob_start();

wp_start_cross_origin_isolation_output_buffer();
echo '<img src="https://external.example.com/image.jpg" />';

// Flush the inner buffer to trigger the callback, sending processed output to the outer buffer.
ob_end_flush();
$output = ob_get_clean();

$this->assertStringContainsString( 'crossorigin="anonymous"', $output );
}
}
71 changes: 71 additions & 0 deletions tests/phpunit/tests/media/wpGetChromiumMajorVersion.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
<?php

/**
* Tests for the `wp_get_chromium_major_version()` function.
*
* @group media
* @covers ::wp_get_chromium_major_version
*/
class Tests_Media_wpGetChromiumMajorVersion extends WP_UnitTestCase {

/**
* Original HTTP_USER_AGENT value.
*
* @var string|null
*/
private $original_user_agent;

public function set_up() {
parent::set_up();
$this->original_user_agent = isset( $_SERVER['HTTP_USER_AGENT'] ) ? $_SERVER['HTTP_USER_AGENT'] : null;
}

public function tear_down() {
if ( null === $this->original_user_agent ) {
unset( $_SERVER['HTTP_USER_AGENT'] );
} else {
$_SERVER['HTTP_USER_AGENT'] = $this->original_user_agent;
}
parent::tear_down();
}

public function test_returns_null_when_no_user_agent() {
unset( $_SERVER['HTTP_USER_AGENT'] );
$this->assertNull( wp_get_chromium_major_version() );
}

public function test_returns_null_for_empty_user_agent() {
$_SERVER['HTTP_USER_AGENT'] = '';
$this->assertNull( wp_get_chromium_major_version() );
}

public function test_returns_null_for_firefox() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; rv:128.0) Gecko/20100101 Firefox/128.0';
$this->assertNull( wp_get_chromium_major_version() );
}

public function test_returns_null_for_safari() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 14_5) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.5 Safari/605.1.15';
$this->assertNull( wp_get_chromium_major_version() );
}

public function test_returns_version_for_chrome() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36';
$this->assertSame( 137, wp_get_chromium_major_version() );
}

public function test_returns_version_for_edge() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36 Edg/137.0.0.0';
$this->assertSame( 137, wp_get_chromium_major_version() );
}

public function test_returns_version_for_opera() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36 OPR/122.0.0.0';
$this->assertSame( 136, wp_get_chromium_major_version() );
}

public function test_returns_version_for_older_chrome() {
$_SERVER['HTTP_USER_AGENT'] = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.75 Safari/537.36';
$this->assertSame( 100, wp_get_chromium_major_version() );
}
}