PHP: fix ambiguous wording in eval() paragraph #158
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original sentence "Both of these must not be used" was changed to "Neither of these must be used" in 4361cec (PR 65), based on a suggestion noting the original sentence read weird. However, it seems to me that "Neither of these must be used" can be read as "there is no requirement to use either" instead of the intended prohibition. This commit changes the sentence to "These must not be used", which keeps the clear prohibition from "must not".
jrfnl
reviewed
Feb 4, 2026
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
AFAICS the proposed change makes the text more ambiguous. Recommend: close.
/cc @GaryJones Second opinion from a native speaker highly appreciated.
Member
|
To me 'neither of these must be used' read more natural to me, but I'm not a natural speaker 🤷🏼♂️ So I'm also for closing this PR. |
Contributor
Author
|
Thanks for your input. Let's wait a couple of days in case Gary is available to weigh in. If he's not, I don't oppose closing this PR since I seem to be the only one who sees the ambiguity in "Neither of these must be used" ("there is no requirement to use either" instead of the intended prohibition). |
GaryJones
requested changes
Feb 5, 2026
Co-authored-by: Gary Jones <github@garyjones.io>
jrfnl
approved these changes
Feb 6, 2026
dingo-d
approved these changes
Feb 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original sentence "Both of these must not be used" was changed to "Neither of these must be used" in 4361cec (PR #65), based on a suggestion noting the original sentence read weird.
However, it seems to me that "Neither of these must be used" can be read as "there is no requirement to use either" instead of the intended prohibition.
This PR changes the sentence to "These must not be used", which keeps the clear prohibition from "must not".
Note: I'm not a native English speaker, so I could be wrong about the ambiguity. Happy to hear other opinions on this.