Merged
Conversation
jrfnl
requested changes
May 2, 2022
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
This document still contains a LOT of HTML which should probably be converted to markdown properly.
dingo-d
reviewed
May 2, 2022
dingo-d
reviewed
May 2, 2022
dingo-d
reviewed
May 2, 2022
dingo-d
reviewed
May 2, 2022
dingo-d
requested changes
May 2, 2022
Member
dingo-d
left a comment
dingo-d
left a comment
There was a problem hiding this comment.
Left some minor comments, otherwise looks good to me 👍🏼
Member
Author
|
This can be re-reviewed now, I think I've got everything 🤞🏼 |
dingo-d
approved these changes
May 2, 2022
jrfnl
reviewed
May 2, 2022
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Just one small remark (and one outside the scope of this PR to be addressed separately).
GaryJones
requested changes
May 3, 2022
GaryJones
approved these changes
May 4, 2022
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
Co-authored-by: Gary Jones <github@garyjones.io> Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>
Member
jrfnl
approved these changes
May 20, 2022
Member
jrfnl
left a comment
jrfnl
left a comment
There was a problem hiding this comment.
Not sure what this was still waiting for. Looks good and with all the approvals, merging this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #66 to update markdown format for https://developer.wordpress.org/coding-standards/wordpress-coding-standards/css/