Merged
Conversation
ntwb
commented
May 2, 2022
| Whitespace can easily accumulate at the end of a line – avoid this, as trailing whitespace is caught as an error in JSHint. One way to catch whitespace buildup is enabling visible whitespace characters within your text editor. | ||
|
|
||
| ### Objects | ||
| ### Object Declarations |
Member
Author
There was a problem hiding this comment.
This removes an ID element conflict with Object further in the file:
jrfnl
approved these changes
May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #66 to update markdown format for https://developer.wordpress.org/coding-standards/wordpress-coding-standards/javascript/#type-checks
This resolves most issues with this file except for these four issues:
For this section of code:
wpcs-docs/wordpress-coding-standards/javascript.md
Lines 44 to 48 in 776433c
This can be updated in a follow up pull request using the footnotes format:
https://www.markdownguide.org/extended-syntax/#footnotes
Possibly the above might not play well in the parser, so performing that as a separate PR will help if it needs to be reverted if it doesn't work, if that's the case using
^1or¹can work in this case