Add support for compound PK batch ops in test suite#16
Add support for compound PK batch ops in test suite#16
Conversation
|
Yeah, that's exactly right: that should be a feature flag. You can move the Firestore test here if it's easy to do, since I think I put it in there only to cover an immediate use case in a quick and dirty way. One thing I noticed though, is that the primary key in your new Or in the top of the collection definition: Have you checked whether the compound index is really created by Dexie for example? |
- also added new backend feature support flag to check support of
66f2c26 to
451bea1
Compare
|
So I've had a look in the firestore repo and I don't actually see that test; I think I misunderstood that earlier in the test output (I was a bit rushed submitting this PR). As far as I can see running the test suite now, that test does not run for the firestore repo. Unless you know of the test existing in the firestore repo, let's ignore that. The actual issue I have now is: Now inside the TypeORM submodule repo, from what I can see, it imports and resolves the I'm feeling like I'm not using the
Yes I think you're right here. I've updated the commit in this PR. |
|
I think you're running into the issue that if you install any new package through |
I'm not entirely sure if I'm going about this the correct way.
I saw the empty
should support batch operations with compound primary keystest and thought maybe that's what I should expand on (and which I did).Then I realized we'd need some new backend feature support flag for compound keys, so I added in
compoundPrimaryKeys.Though I noticed running the test suite from the root storex workspace directory, the
should support batch operations with compound primary keystest runs for the firestore backend (which I haven't touched), so maybe I'm wrong about the need for a new feature support flag.How far am I off the correct path here @ShishKabab ?