Fix up thumbnailer sample programs#24
Merged
Merged
Conversation
…l-Sai1 (makes it easier to use this program as a Linux thumbnailer).
Wunkolo
reviewed
May 9, 2026
| "\tThumbnail (filename) (output)\n" | ||
| "\tWunkolo - Wunkolo@gmail.com"; | ||
|
|
||
| void bgraToRgba(std::byte* Pixels, std::size_t PixelCount) |
Owner
There was a problem hiding this comment.
I would use an std::span<std::byte> here as the only argument. Also maybe ConvertBGRA8ToRGBA8 for the function name.
Wunkolo
reviewed
May 9, 2026
| continue; | ||
| } | ||
| const std::uintmax_t FileSize = std::filesystem::file_size(FilePath); | ||
| std::printf("Input and output paths required.\n"); |
Owner
There was a problem hiding this comment.
This can be std::puts since it's not doing any actual formatting.
Owner
|
No need to worry about any build issues on the |
Contributor
Author
|
Oops, I accidentally committed my local flake file, reverting that. |
Owner
|
Looks good to me! This closes #23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #23
Tested on Linux with Sai1 and Sai2 files.