Layout issue for split view mode on iPad#43
Open
git103 wants to merge 3 commits intoXAM-Consulting:masterfrom
Open
Layout issue for split view mode on iPad#43git103 wants to merge 3 commits intoXAM-Consulting:masterfrom
git103 wants to merge 3 commits intoXAM-Consulting:masterfrom
Conversation
git103
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered an issue getting split view mode on an iPad Pro to work correctly with SlideOverKit. For instance when I held the iPad in landscape orientation and put my app into a split view at 50% screen width the SlideMenuView would render at a wrong position.
This is because an assumption was made that if width < height that the app in in portrait mode. This is not always true when the view is split.
I've implemented a fix for this issue.