Add Range Display to Mega Torch and Dread Lamp#270
Open
Syer10 wants to merge 1 commit intoXalcon:mc/1.21.1from
Open
Add Range Display to Mega Torch and Dread Lamp#270Syer10 wants to merge 1 commit intoXalcon:mc/1.21.1from
Syer10 wants to merge 1 commit intoXalcon:mc/1.21.1from
Conversation
Owner
|
Thank you for this PR. I have a very basic client-side-only implementation in 1.20, but i was never super happy with how it works, especially when multiple torches overlap. I dont have much time during the week, I'll take a closer look on the weekend - but I'm unsure what you mean its server wide. Each player still has to explicitly enable it in the settings - but it will show all torches? Or will you need to toggle it per torch? Either way, I'll try to find some time this weekend to review this. |
Author
|
Each Torch now has a GUI that enables the range preview, the range preview is then shown to all players since it's a part of the Torch itself, and not the client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GUI
Inside Range
Outside Range
Notes