Skip to content

feat(core/vm): implement EIP-7883 - ModExp Gas Cost Increase #31606 #32015#2123

Merged
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:eip-7883
Mar 10, 2026
Merged

feat(core/vm): implement EIP-7883 - ModExp Gas Cost Increase #31606 #32015#2123
AnilChinchawale merged 1 commit intoXinFinOrg:dev-upgradefrom
gzliudan:eip-7883

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Mar 2, 2026

Proposed changes

implement EIP 7883:

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Changes that don't change source code or tests
  • docs: Documentation only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that neither fixes a bug nor adds a feature
  • revert: Revert something
  • style: Changes that do not affect the meaning of the code
  • test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copilot AI review requested due to automatic review settings March 2, 2026 06:22
@coderabbitai
Copy link

coderabbitai bot commented Mar 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b757f768-27ff-4402-b733-cfb6c6380657

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements EIP-7883-related changes to the bigModExp precompile, wiring the updated behavior into fork-based precompile selection (including a new Osaka precompile set) and adding test vectors/benchmarks.

Changes:

  • Added an Osaka fork precompile set and updated active precompile selection to account for rules.IsOsaka.
  • Extended bigModExp with new feature flags and updated its gas calculation / input handling accordingly.
  • Added JSON test vectors and new unit test/benchmark coverage for the EIP-7883 modexp variant.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
core/vm/testdata/precompiles/modexp_eip7883.json Adds modexp EIP-7883 test vectors used by JSON-driven precompile tests/benchmarks.
core/vm/contracts_test.go Registers a new modexp variant address for tests and adds JSON-based test + benchmark entrypoints for EIP-7883.
core/vm/contracts.go Introduces Osaka precompile set selection and updates bigModExp behavior/configuration for EIP-7883.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gzliudan gzliudan force-pushed the eip-7883 branch 2 times, most recently from e3bfd1b to 3dc6f06 Compare March 3, 2026 10:13
@gzliudan gzliudan changed the title feat(core/vm): implement EIP 7883 #31606 #32015 feat(core/vm): implement EIP-7883 - ModExp Gas Cost Increase #31606 #32015 Mar 3, 2026
…#31606 ethereum#32015

https://eips.ethereum.org/EIPS/eip-7883

---------

Co-authored-by: MariusVanDerWijden <m.vanderwijden@live.de>
Co-authored-by: Felix Lange <fjl@twurst.com>
@AnilChinchawale AnilChinchawale merged commit 5bb1f03 into XinFinOrg:dev-upgrade Mar 10, 2026
13 checks passed
@gzliudan gzliudan deleted the eip-7883 branch March 10, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants