perf(core/txpool,miner): speed up pending transaction ordering with uint256 #29008 by gzliudan · Pull Request #2159 · XinFinOrg/XDPoSChain

gzliudan · 2026-03-09T11:30:44Z

Proposed changes

Switch LazyTransaction gas caps from *big.Int to *uint256.Int and convert once at pending retrieval time.

In miner ordering, keep fee comparisons on uint256 and precompute TRC21 gas price in uint256 form to avoid repeated big-int conversions in heap comparisons.

Also update affected tests and call sites in legacypool/worker/helper paths.

Compatibility: LazyTransaction exported field types changed (GasFeeCap/GasTipCap).

Ref: ethereum#29008

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
Tested the backwards compatibility.
Tested with XDC nodes running this version co-exist with those running the previous version.
Relevant documentation has been updated as part of this PR
N/A

coderabbitai · 2026-03-09T11:31:03Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1a86fc89-0c7e-4315-b5e6-b228032e15b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR aims to speed up “pending” transaction handling (miner selection and txpool retrieval) by pre-filtering pending txs by fee/tip constraints and by switching fee comparisons to uint256 to reduce allocations/overhead.

Changes:

Update the txpool Pending API to accept (minTip, baseFee *uint256.Int) and propagate the new signature through ETH protocol syncing, RPC backends, miner, and tests.
Convert txpool.LazyTransaction fee fields and miner ordering logic to *uint256.Int and add tests around min-tip/base-fee filtering behavior.
Refactor mining configuration into ethconfig.Config.Miner (type miner.Config), add miner-side gas tip setting/validation, and adjust gas-limit defaults.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
params/protocol_params.go	Adjusts XDC gas-limit constant and removes `TargetGasLimit` global.
miner/worker_test.go	Adds unit tests for worker gas tip validation and copy semantics.
miner/worker.go	Wires miner config vs chain config, adds `setGasTip`, uses `uint256` fees in tx ordering inputs, and uses new txpool `Pending` filter.
miner/ordering_test.go	Updates ordering tests to populate `LazyTransaction` fee fields with `uint256`.
miner/ordering.go	Switches miner fee/tip computations and comparisons to `uint256` and pre-converts TRC21 gas price.
miner/miner.go	Introduces `miner.Config` + defaults, updates miner constructor signature, and adds `SetGasTip`.
eth/sync.go	Updates peer tx sync path to use new `Pending(nil, nil)` signature.
eth/protocol.go	Updates `txPool` interface `Pending` signature to `uint256` params.
eth/helper_test.go	Updates test txpool mock to satisfy new `Pending` signature and `LazyTransaction` fee types.
eth/ethconfig/gen_config.go	Moves miner-related TOML marshalling to `Miner miner.Config` field.
eth/ethconfig/config.go	Moves mining options under `Config.Miner` and updates defaults / gencodec generation settings.
eth/backend.go	Sanitizes miner config, wires miner creation with `config.Miner`, and updates GPO initialization.
eth/api_miner.go	Updates `miner_setGasPrice` flow to set txpool + miner gas tip and copy gas price internally.
eth/api_backend.go	Updates pending tx retrieval to new `Pending(nil, nil)` signature.
core/txpool/txpool.go	Updates `TxPool.Pending` signature and forwards filter params to subpools.
core/txpool/subpool.go	Updates `LazyTransaction` fee fields to `uint256` and updates `SubPool.Pending` signature.
core/txpool/legacypool/legacypool_test.go	Adds tests for min-tip/base-fee pending filtering behavior.
core/txpool/legacypool/legacypool.go	Implements new `Pending(minTip, baseFee)` filtering and converts tx fee fields to `uint256`.
core/chain_makers.go	Replaces removed target gas-limit usage with `XDCGenesisGasLimit`.
core/bench_test.go	Replaces removed target gas-limit usage with `XDCGenesisGasLimit`.
console/console_test.go	Updates test config wiring to new `ethconfig.Config.Miner` struct.
cmd/utils/flags.go	Routes miner flags into `cfg.Miner` (and adds `setMiner`).
cmd/XDC/main.go	Removes runtime mutation of removed `params.TargetGasLimit`.
accounts/abi/bind/v2/util_test.go	Adjusts gas price in deployment test to be safely above base fee.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

miner/worker.go

Copilot · 2026-03-09T11:37:33Z

eth/backend.go

+	eth.miner = miner.New(eth, &config.Miner, eth.blockchain.Config(), eth.EventMux(), eth.engine, stack.Config().AnnounceTxs)
+	eth.miner.SetExtra(makeExtraData(config.Miner.ExtraData))


config.Miner.ExtraData is hexutil.Bytes, but makeExtraData expects []byte. This call won’t compile without converting hexutil.Bytes to []byte (and ideally copying to avoid aliasing if the underlying slice might be reused).

Copilot · 2026-03-09T11:37:33Z

cmd/utils/flags.go

+	if ctx.IsSet(MinerExtraDataFlag.Name) {
+		cfg.ExtraData = []byte(ctx.String(MinerExtraDataFlag.Name))
+	}


miner.Config.ExtraData is hexutil.Bytes, so assigning a []byte directly won’t compile. Convert the CLI string to hexutil.Bytes (or change the config field type back to []byte) so the miner extra-data flag wiring builds correctly.

Copilot · 2026-03-09T11:37:33Z

params/protocol_params.go

 	GenesisGasLimit      uint64 = 4712388            // Gas limit of the Genesis block.
-	XDCGenesisGasLimit   uint64 = 84000000
+	XDCGenesisGasLimit   uint64 = 42000000



This PR changes params.XDCGenesisGasLimit from 84,000,000 to 42,000,000, which feeds into miner defaults (miner.DefaultConfig.GasCeil) and other helpers (e.g., core.CalcGasLimit targets). That’s a significant behavioral/default change but it’s not described in the PR metadata/title; please confirm it’s intentional and add rationale (or revert if unrelated to the blobpool pending speedup work).

Miner configuration is unified under [Eth.Miner] (GasCeil/GasPrice/Etherbase/ExtraData), replacing legacy top-level [Eth] miner keys. Operational impact: existing config files using [Eth].GasPrice/[Eth].Etherbase/[Eth].ExtraData must be migrated before upgrade. Behavior update: gasprice=0 remains valid; only negative gas prices are sanitized at startup. Default change: XDCGenesisGasLimit is reduced to 42,000,000 and now feeds miner default GasCeil (including default --miner-gaslimit), so nodes relying on defaults should review capacity expectations.

Synchronize miner gas tip updates across subsystems when RPC updates gas price. - update eth miner API to apply gas tip changes to both txpool and miner - add miner/worker SetGasTip path and initialize worker tip from config - adjust bind util test to use params.GWei over base fee Ref: ethereum#28933

…ethereum#29005 Introduce dynamic-fee pre-filtering in txpool pending retrieval to reduce allocations and downstream processing work during mining and tx propagation. What changed: - Change the `Pending` API from `Pending(enforceTips bool)` to `Pending(minTip *uint256.Int, baseFee *uint256.Int)` in txpool interfaces. - Implement pre-filtering in `legacypool.Pending` by comparing effective tip against the provided `minTip/baseFee` for non-local, non-special txs. - Update call sites to the new API: - miner work assembly (`miner/worker.go`) - tx sync (`eth/sync.go`) - pool transaction retrieval (`eth/api_backend.go`) - protocol/test interfaces (`eth/protocol.go`, `eth/helper_test.go`). Tests: - Add targeted coverage for pending filtering semantics in `core/txpool/legacypool/legacypool_test.go`, including: - minTip threshold boundary behavior - baseFee-aware effective tip filtering - local/special transaction exemption behavior - dynamic-fee boundary behavior when baseFee is nil. Impact: - Preserves existing behavior while making pending selection cheaper for downstream consumers. - Improves confidence in edge-case behavior through dedicated tests.

…int256 ethereum#29008 Switch LazyTransaction gas caps from *big.Int to *uint256.Int and convert once at pending retrieval time. In miner ordering, keep fee comparisons on uint256 and precompute TRC21 gas price in uint256 form to avoid repeated big-int conversions in heap comparisons. Also update affected tests and call sites in legacypool/worker/helper paths. Compatibility: LazyTransaction exported field types changed (GasFeeCap/GasTipCap).

AnilChinchawale · 2026-03-10T13:24:23Z

@gzliudan conflict

Copilot AI review requested due to automatic review settings March 9, 2026 11:30

Copilot started reviewing on behalf of gzliudan March 9, 2026 11:31 View session

gzliudan force-pushed the blobpool-pending-speedup branch from 5b668fb to 8e70fad Compare March 9, 2026 11:34

Copilot AI reviewed Mar 9, 2026

View reviewed changes

gzliudan added 3 commits March 9, 2026 19:46

gzliudan force-pushed the blobpool-pending-speedup branch from 8e70fad to b526996 Compare March 9, 2026 11:54

gzliudan changed the title ~~Blobpool pending speedup~~ perf(core/txpool,miner): speed up pending transaction ordering with uint256 #29008 Mar 9, 2026

gzliudan force-pushed the blobpool-pending-speedup branch from b526996 to 6d33068 Compare March 9, 2026 14:29

gzliudan requested review from AnilChinchawale, anunay-xin, benjamin202410, liam-lai and wanwiset25 March 10, 2026 02:52

benjamin202410 approved these changes Mar 10, 2026

View reviewed changes

wanwiset25 approved these changes Mar 10, 2026

View reviewed changes

anunay-xin approved these changes Mar 10, 2026

View reviewed changes

AnilChinchawale approved these changes Mar 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(core/txpool,miner): speed up pending transaction ordering with uint256 #29008#2159

perf(core/txpool,miner): speed up pending transaction ordering with uint256 #29008#2159
gzliudan wants to merge 4 commits intoXinFinOrg:dev-upgradefrom
gzliudan:blobpool-pending-speedup

gzliudan commented Mar 9, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 9, 2026 •

edited

Loading

Review skipped

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

AnilChinchawale commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		eth.miner = miner.New(eth, &config.Miner, eth.blockchain.Config(), eth.EventMux(), eth.engine, stack.Config().AnnounceTxs)
		eth.miner.SetExtra(makeExtraData(config.Miner.ExtraData))

Conversation

gzliudan commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Types of changes

Impacted Components

Checklist

Uh oh!

coderabbitai bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

AnilChinchawale commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gzliudan commented Mar 9, 2026 •

edited

Loading

coderabbitai bot commented Mar 9, 2026 •

edited

Loading