refactor(core/txpool): no need to log loud rotate if no local txs #29083#2164
refactor(core/txpool): no need to log loud rotate if no local txs #29083#2164gzliudan wants to merge 1 commit intoXinFinOrg:dev-upgradefrom
Conversation
…ereum#29083 * core/txpool: no need to run rotate if no local txs Signed-off-by: jsvisa <delweng@gmail.com> * Revert "core/txpool: no need to run rotate if no local txs" This reverts commit 17fab17. Signed-off-by: jsvisa <delweng@gmail.com> * use Debug if todo is empty Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com>
gzliudan
requested review from
AnilChinchawale,
anunay-xin,
benjamin202410,
Copilot,
liam-lai and
wanwiset25
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR refactors txpool journaling rotation logging to avoid emitting an Info-level message when there are no local transactions to journal, reducing noisy logs during periodic journal rotations.
Changes:
- Adjusts the log level used after regenerating the local transaction journal, downgrading to debug in the “empty” case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| log.Info("Regenerated local transaction journal", "transactions", journaled, "accounts", len(all)) | ||
|
|
||
| logger := log.Info | ||
| if len(all) == 0 { |
There was a problem hiding this comment.
The log level switch uses len(all) == 0, but the intent (per PR title) is to downgrade when there are no local txs. Since all is keyed by accounts, it’s possible for len(all) > 0 while journaled == 0 (e.g., an account entry exists but its tx list is empty), which would still emit an Info-level log. Consider switching the condition to journaled == 0 (or journaled == 0 && len(all) == 0 if you specifically want ‘no accounts’) to match the actual ‘no txs’ case.
| if len(all) == 0 { | |
| if journaled == 0 { |
Proposed changes
Ref: ethereum#29083
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that