Update bootnodes and enode configuration files for XDC MainNet#248
Merged
AnilChinchawale merged 2 commits intoXinFinOrg:masterfrom Mar 18, 2026
Merged
Update bootnodes and enode configuration files for XDC MainNet#248AnilChinchawale merged 2 commits intoXinFinOrg:masterfrom
AnilChinchawale merged 2 commits intoXinFinOrg:masterfrom
Conversation
📝 WalkthroughWalkthroughThe PR updates the mainnet bootstrap node configuration by adding 17 new enode entries across two files. In Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gzliudan
approved these changes
Mar 6, 2026
There was a problem hiding this comment.
Pull request overview
Updates the XDC MainNet peer discovery configuration by modifying the maintained lists of enode URLs used for bootstrapping and peer addition.
Changes:
- Refreshes the enode entries in
mainnet/enode.txt. - Expands/updates the bootnode enode entries in
mainnet/bootnodes.list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mainnet/enode.txt | Updates the enode peer list intended for scripted peer addition. |
| mainnet/bootnodes.list | Updates the bootnodes list consumed at startup to build the --bootnodes argument. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+19
to
+28
| enode://874589626a2b4fd7c57202533315885815eba51dbc434db88bbbebcec9b22cf2a01eafad2fd61651306fe85321669a30b3f41112eca230137ded24b86e064ba8@5.189.144.192:30303 | ||
| enode://ccdef92053c8b9622180d02a63edffb3e143e7627737ea812b930eacea6c51f0c93a5da3397f59408c3d3d1a9a381f7e0b07440eae47314685b649a03408cfdd@37.60.243.5:30303 | ||
| enode://12711126475d7924af98d359e178f71c5d9607de32d2c5b4ab1afff4b0bb16b793b4bbda0a42bf41a309e5349b6106d053ae4ae92aa848b5879e3ef3687c6203@89.117.49.48:30303 | ||
| enode://81edfecc3df6994679daf67858ae34c0ae91aac944a84b09171532b45ad0f5d0c896eb8c023df04eaa2db743f5fccdf18cf7e2d12120d37a2c142a3be0a348cd@38.102.87.174:30303 | ||
| enode://053ba696174e7f115e38f0e3963d0035ac20dc18e9a5c5873f9e90fe338d777f726d68d053c987416ec0bd97d4d818c59a8a23bc9ea854069ea2310846e27e7d@162.250.189.221:30303 | ||
| enode://b3ce1f8894af033cc2adbcb0836fe18d283af8574c451e385fd362165a6e5eded1b59b640c4d92048283bad9855721345a28ebaf28f66ace00a7134871d1e2a2@38.143.58.166:30303 | ||
| enode://938f2e3f409a12573e6da6460b6497c45e2bec393756b989b8874f647911cca39d0ffef8554a45698a8f21a7e870288beb638b3770537a12118e30bd6f9ae806@109.199.104.176:30303 | ||
| enode://47350ef305fb1406818a621a0f11144a72d560835a860607b331cef46ac82ea79c7df6bb5e5dba4147a489d9c77bc527f2500ce753fece817bc1a890eb05b886@185.252.233.29:30303 | ||
| enode://2ac0472c39e3e0be89bc021689d4c015c455e9f2fe2101bee80b61bba6224c810d200a6d6d17038d5826d522edbcb73a6bc44e492cd5f06a5377aa6eee03335b@144.126.136.27:30303 | ||
| enode://2c19c70a9c4134936926bbf1293e6fdc316401cc4f2cdb561dd5d2710f5b34ced22927173facabbeabe512f2e244994d65bc2f2d738db3bf805238f71fb9e490@205.172.57.65:30303 |
There was a problem hiding this comment.
The enode entries added here duplicate enodes that are already present earlier in this same file (see lines 1–17). This makes enode.txt contain repeated peers, which causes redundant admin.addPeer calls and makes the list harder to maintain. Please remove the duplicated block (or otherwise de-duplicate the file) so each enode appears only once.
Suggested change
| enode://874589626a2b4fd7c57202533315885815eba51dbc434db88bbbebcec9b22cf2a01eafad2fd61651306fe85321669a30b3f41112eca230137ded24b86e064ba8@5.189.144.192:30303 | |
| enode://ccdef92053c8b9622180d02a63edffb3e143e7627737ea812b930eacea6c51f0c93a5da3397f59408c3d3d1a9a381f7e0b07440eae47314685b649a03408cfdd@37.60.243.5:30303 | |
| enode://12711126475d7924af98d359e178f71c5d9607de32d2c5b4ab1afff4b0bb16b793b4bbda0a42bf41a309e5349b6106d053ae4ae92aa848b5879e3ef3687c6203@89.117.49.48:30303 | |
| enode://81edfecc3df6994679daf67858ae34c0ae91aac944a84b09171532b45ad0f5d0c896eb8c023df04eaa2db743f5fccdf18cf7e2d12120d37a2c142a3be0a348cd@38.102.87.174:30303 | |
| enode://053ba696174e7f115e38f0e3963d0035ac20dc18e9a5c5873f9e90fe338d777f726d68d053c987416ec0bd97d4d818c59a8a23bc9ea854069ea2310846e27e7d@162.250.189.221:30303 | |
| enode://b3ce1f8894af033cc2adbcb0836fe18d283af8574c451e385fd362165a6e5eded1b59b640c4d92048283bad9855721345a28ebaf28f66ace00a7134871d1e2a2@38.143.58.166:30303 | |
| enode://938f2e3f409a12573e6da6460b6497c45e2bec393756b989b8874f647911cca39d0ffef8554a45698a8f21a7e870288beb638b3770537a12118e30bd6f9ae806@109.199.104.176:30303 | |
| enode://47350ef305fb1406818a621a0f11144a72d560835a860607b331cef46ac82ea79c7df6bb5e5dba4147a489d9c77bc527f2500ce753fece817bc1a890eb05b886@185.252.233.29:30303 | |
| enode://2ac0472c39e3e0be89bc021689d4c015c455e9f2fe2101bee80b61bba6224c810d200a6d6d17038d5826d522edbcb73a6bc44e492cd5f06a5377aa6eee03335b@144.126.136.27:30303 | |
| enode://2c19c70a9c4134936926bbf1293e6fdc316401cc4f2cdb561dd5d2710f5b34ced22927173facabbeabe512f2e244994d65bc2f2d738db3bf805238f71fb9e490@205.172.57.65:30303 |
Contributor
There was a problem hiding this comment.
@AnilChinchawale please remove duplicate records
Comment on lines
+19
to
+28
| enode://874589626a2b4fd7c57202533315885815eba51dbc434db88bbbebcec9b22cf2a01eafad2fd61651306fe85321669a30b3f41112eca230137ded24b86e064ba8@5.189.144.192:30303 | ||
| enode://ccdef92053c8b9622180d02a63edffb3e143e7627737ea812b930eacea6c51f0c93a5da3397f59408c3d3d1a9a381f7e0b07440eae47314685b649a03408cfdd@37.60.243.5:30303 | ||
| enode://12711126475d7924af98d359e178f71c5d9607de32d2c5b4ab1afff4b0bb16b793b4bbda0a42bf41a309e5349b6106d053ae4ae92aa848b5879e3ef3687c6203@89.117.49.48:30303 | ||
| enode://81edfecc3df6994679daf67858ae34c0ae91aac944a84b09171532b45ad0f5d0c896eb8c023df04eaa2db743f5fccdf18cf7e2d12120d37a2c142a3be0a348cd@38.102.87.174:30303 | ||
| enode://053ba696174e7f115e38f0e3963d0035ac20dc18e9a5c5873f9e90fe338d777f726d68d053c987416ec0bd97d4d818c59a8a23bc9ea854069ea2310846e27e7d@162.250.189.221:30303 | ||
| enode://b3ce1f8894af033cc2adbcb0836fe18d283af8574c451e385fd362165a6e5eded1b59b640c4d92048283bad9855721345a28ebaf28f66ace00a7134871d1e2a2@38.143.58.166:30303 | ||
| enode://938f2e3f409a12573e6da6460b6497c45e2bec393756b989b8874f647911cca39d0ffef8554a45698a8f21a7e870288beb638b3770537a12118e30bd6f9ae806@109.199.104.176:30303 | ||
| enode://47350ef305fb1406818a621a0f11144a72d560835a860607b331cef46ac82ea79c7df6bb5e5dba4147a489d9c77bc527f2500ce753fece817bc1a890eb05b886@185.252.233.29:30303 | ||
| enode://2ac0472c39e3e0be89bc021689d4c015c455e9f2fe2101bee80b61bba6224c810d200a6d6d17038d5826d522edbcb73a6bc44e492cd5f06a5377aa6eee03335b@144.126.136.27:30303 | ||
| enode://2c19c70a9c4134936926bbf1293e6fdc316401cc4f2cdb561dd5d2710f5b34ced22927173facabbeabe512f2e244994d65bc2f2d738db3bf805238f71fb9e490@205.172.57.65:30303 |
There was a problem hiding this comment.
These newly added bootnode entries are duplicates of entries that already exist earlier in bootnodes.list (see lines 1–17). Because start-node.sh concatenates every line into the --bootnodes argument, duplicates add noise and can unnecessarily bloat the command line. Please de-duplicate the list so each bootnode enode appears only once.
Suggested change
| enode://874589626a2b4fd7c57202533315885815eba51dbc434db88bbbebcec9b22cf2a01eafad2fd61651306fe85321669a30b3f41112eca230137ded24b86e064ba8@5.189.144.192:30303 | |
| enode://ccdef92053c8b9622180d02a63edffb3e143e7627737ea812b930eacea6c51f0c93a5da3397f59408c3d3d1a9a381f7e0b07440eae47314685b649a03408cfdd@37.60.243.5:30303 | |
| enode://12711126475d7924af98d359e178f71c5d9607de32d2c5b4ab1afff4b0bb16b793b4bbda0a42bf41a309e5349b6106d053ae4ae92aa848b5879e3ef3687c6203@89.117.49.48:30303 | |
| enode://81edfecc3df6994679daf67858ae34c0ae91aac944a84b09171532b45ad0f5d0c896eb8c023df04eaa2db743f5fccdf18cf7e2d12120d37a2c142a3be0a348cd@38.102.87.174:30303 | |
| enode://053ba696174e7f115e38f0e3963d0035ac20dc18e9a5c5873f9e90fe338d777f726d68d053c987416ec0bd97d4d818c59a8a23bc9ea854069ea2310846e27e7d@162.250.189.221:30303 | |
| enode://b3ce1f8894af033cc2adbcb0836fe18d283af8574c451e385fd362165a6e5eded1b59b640c4d92048283bad9855721345a28ebaf28f66ace00a7134871d1e2a2@38.143.58.166:30303 | |
| enode://938f2e3f409a12573e6da6460b6497c45e2bec393756b989b8874f647911cca39d0ffef8554a45698a8f21a7e870288beb638b3770537a12118e30bd6f9ae806@109.199.104.176:30303 | |
| enode://47350ef305fb1406818a621a0f11144a72d560835a860607b331cef46ac82ea79c7df6bb5e5dba4147a489d9c77bc527f2500ce753fece817bc1a890eb05b886@185.252.233.29:30303 | |
| enode://2ac0472c39e3e0be89bc021689d4c015c455e9f2fe2101bee80b61bba6224c810d200a6d6d17038d5826d522edbcb73a6bc44e492cd5f06a5377aa6eee03335b@144.126.136.27:30303 | |
| enode://2c19c70a9c4134936926bbf1293e6fdc316401cc4f2cdb561dd5d2710f5b34ced22927173facabbeabe512f2e244994d65bc2f2d738db3bf805238f71fb9e490@205.172.57.65:30303 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
mainnet/enode.txt (1)
102-103: Pre-existing duplicate entry at lines 102-103.Lines 102 and 103 contain identical entries (
enode://91e59fa...@149.102.140.32:30304). While not introduced by this PR, consider cleaning this up as part of this change.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@mainnet/enode.txt` around lines 102 - 103, There is a duplicate enode entry "enode://91e59fa1b034ae35e9f4e8a99cc6621f09d74e76a6220abb6c93b29ed41a9e1fc4e5b70e2c5fc43f883cffbdcd6f4f6cbc1d23af077f28c2aecc22403355d4b1@149.102.140.32:30304" present on two consecutive lines (the repeated string); remove the redundant line so each enode is unique (keep one instance of the enode string) and ensure no other exact duplicates remain in mainnet/enode.txt.mainnet/bootnodes.list (1)
102-103: Pre-existing duplicate entry at lines 102-103.Same as in
enode.txt, lines 102 and 103 contain identical entries. Consider cleaning this up as part of this change.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@mainnet/bootnodes.list` around lines 102 - 103, The file contains a duplicate enode entry "enode://91e59fa1b034ae35e9f4e8a99cc6621f09d74e76a6220abb6c93b29ed41a9e1fc4e5b70e2c5fc43f883cffbdcd6f4f6cbc1d23af077f28c2aecc22403355d4b1@149.102.140.32:30304" (appears twice); remove the redundant line so the enode appears only once in mainnet/bootnodes.list, then verify the remaining list matches enode.txt (or remove duplicate there if you prefer central cleanup) and ensure no extra blank lines or trailing whitespace remain.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mainnet/bootnodes.list`:
- Around line 18-34: The file mainnet/bootnodes.list contains exact duplicate
enode entries (the block added in the diff duplicates the first 17 entries);
remove the duplicated block so each enode appears only once in
mainnet/bootnodes.list and verify start-node.sh (referenced as
start-node.sh:17-25) will still build the --bootnodes argument from the single,
unique list—ensure no other duplicates remain.
In `@mainnet/enode.txt`:
- Around line 18-34: The file contains a duplicated block of enode entries (the
second block starting with enode://e1a69a7d7665... and repeating the same 17
entries) which will cause peer.sh to call admin.addPeer() twice for each node;
remove the duplicate entries so each enode string appears only once (keep the
first occurrence of each enode like enode://e1a69a7d7665... and delete the
repeated block), ensuring the remaining list contains only unique enode entries
to avoid redundant addPeer calls.
---
Nitpick comments:
In `@mainnet/bootnodes.list`:
- Around line 102-103: The file contains a duplicate enode entry
"enode://91e59fa1b034ae35e9f4e8a99cc6621f09d74e76a6220abb6c93b29ed41a9e1fc4e5b70e2c5fc43f883cffbdcd6f4f6cbc1d23af077f28c2aecc22403355d4b1@149.102.140.32:30304"
(appears twice); remove the redundant line so the enode appears only once in
mainnet/bootnodes.list, then verify the remaining list matches enode.txt (or
remove duplicate there if you prefer central cleanup) and ensure no extra blank
lines or trailing whitespace remain.
In `@mainnet/enode.txt`:
- Around line 102-103: There is a duplicate enode entry
"enode://91e59fa1b034ae35e9f4e8a99cc6621f09d74e76a6220abb6c93b29ed41a9e1fc4e5b70e2c5fc43f883cffbdcd6f4f6cbc1d23af077f28c2aecc22403355d4b1@149.102.140.32:30304"
present on two consecutive lines (the repeated string); remove the redundant
line so each enode is unique (keep one instance of the enode string) and ensure
no other exact duplicates remain in mainnet/enode.txt.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9d63ec69-3b82-406d-b3c2-025e0d698697
📒 Files selected for processing (2)
mainnet/bootnodes.listmainnet/enode.txt
Comment on lines
+18
to
+34
| enode://e1a69a7d766576e694adc3fc78d801a8a66926cbe8f4fe95b85f3b481444700a5d1b6d440b2715b5bb7cf4824df6a6702740afc8c52b20c72bc8c16f1ccde1f3@149.102.140.32:30303 | ||
| enode://874589626a2b4fd7c57202533315885815eba51dbc434db88bbbebcec9b22cf2a01eafad2fd61651306fe85321669a30b3f41112eca230137ded24b86e064ba8@5.189.144.192:30303 | ||
| enode://ccdef92053c8b9622180d02a63edffb3e143e7627737ea812b930eacea6c51f0c93a5da3397f59408c3d3d1a9a381f7e0b07440eae47314685b649a03408cfdd@37.60.243.5:30303 | ||
| enode://12711126475d7924af98d359e178f71c5d9607de32d2c5b4ab1afff4b0bb16b793b4bbda0a42bf41a309e5349b6106d053ae4ae92aa848b5879e3ef3687c6203@89.117.49.48:30303 | ||
| enode://81edfecc3df6994679daf67858ae34c0ae91aac944a84b09171532b45ad0f5d0c896eb8c023df04eaa2db743f5fccdf18cf7e2d12120d37a2c142a3be0a348cd@38.102.87.174:30303 | ||
| enode://053ba696174e7f115e38f0e3963d0035ac20dc18e9a5c5873f9e90fe338d777f726d68d053c987416ec0bd97d4d818c59a8a23bc9ea854069ea2310846e27e7d@162.250.189.221:30303 | ||
| enode://b3ce1f8894af033cc2adbcb0836fe18d283af8574c451e385fd362165a6e5eded1b59b640c4d92048283bad9855721345a28ebaf28f66ace00a7134871d1e2a2@38.143.58.166:30303 | ||
| enode://938f2e3f409a12573e6da6460b6497c45e2bec393756b989b8874f647911cca39d0ffef8554a45698a8f21a7e870288beb638b3770537a12118e30bd6f9ae806@109.199.104.176:30303 | ||
| enode://47350ef305fb1406818a621a0f11144a72d560835a860607b331cef46ac82ea79c7df6bb5e5dba4147a489d9c77bc527f2500ce753fece817bc1a890eb05b886@185.252.233.29:30303 | ||
| enode://2ac0472c39e3e0be89bc021689d4c015c455e9f2fe2101bee80b61bba6224c810d200a6d6d17038d5826d522edbcb73a6bc44e492cd5f06a5377aa6eee03335b@144.126.136.27:30303 | ||
| enode://2c19c70a9c4134936926bbf1293e6fdc316401cc4f2cdb561dd5d2710f5b34ced22927173facabbeabe512f2e244994d65bc2f2d738db3bf805238f71fb9e490@205.172.57.65:30303 | ||
| enode://86ca3a228abf44c06fbf53544aca980b2473e17dcf84879835c0e7a366474727cdb3cf50c7d306dd079d75ba658efe5b9b896e44a9863c7eb025377d291f1eb5@167.224.64.233:30303 | ||
| enode://078efd1cbbd708c41bfc08f54f5610050804587bc8e30341501d34bbfdde68aa051de7a2c662b76dc47e822fe4f20ea85358abde11f7d52fbef74df54ad69469@162.250.189.152:30303 | ||
| enode://5f32d5fc76a951f07d3866a794809d70658acd8c8e843607dcc13e8f835725cca52cd1cdab0581f218ac9f689d2c1ec71e4fb5ee1d766222471b7e9c7a4f1098@104.152.209.76:30303 | ||
| enode://c8a53a7bd5f926f460816af8883e3c7d60753a8f8df04609e1e86f49a6def3c7029f732b2f045807895accf26da3145c8bcfd5a78691ecf39945e340812cf7e9@209.126.1.10:30303 | ||
| enode://f8848e405142b8e88f054fe85ac5e4a75cfd7e353aee7e66797719828d3d5aa2cd62f1355140c0852d3dcb2439a076234c77415ca701318ea1f69a496a0b4b32@109.123.232.199:30303 | ||
| enode://0857894c01314e75520fbdb7e37869666f230c8ab96c0e3067561077209e8f48a9cefb3a71c3c8094448629c152f22c2e5e66bb7ed2c38bfbd9f24941f571beb@103.7.54.103:30303 |
There was a problem hiding this comment.
Duplicate entries detected: Lines 18-34 are exact copies of lines 1-17.
Same issue as in enode.txt — the newly added bootnode entries duplicate the existing entries at the top of the file. The start-node.sh script (see mainnet/start-node.sh:17-25) concatenates all lines into the --bootnodes CLI argument, resulting in each of these 17 nodes appearing twice in the comma-separated list.
🐛 Proposed fix: Remove duplicate entries
enode://0857894c01314e75520fbdb7e37869666f230c8ab96c0e3067561077209e8f48a9cefb3a71c3c8094448629c152f22c2e5e66bb7ed2c38bfbd9f24941f571beb@103.7.54.103:30303
-enode://e1a69a7d766576e694adc3fc78d801a8a66926cbe8f4fe95b85f3b481444700a5d1b6d440b2715b5bb7cf4824df6a6702740afc8c52b20c72bc8c16f1ccde1f3@149.102.140.32:30303
-enode://874589626a2b4fd7c57202533315885815eba51dbc434db88bbbebcec9b22cf2a01eafad2fd61651306fe85321669a30b3f41112eca230137ded24b86e064ba8@5.189.144.192:30303
-enode://ccdef92053c8b9622180d02a63edffb3e143e7627737ea812b930eacea6c51f0c93a5da3397f59408c3d3d1a9a381f7e0b07440eae47314685b649a03408cfdd@37.60.243.5:30303
-enode://12711126475d7924af98d359e178f71c5d9607de32d2c5b4ab1afff4b0bb16b793b4bbda0a42bf41a309e5349b6106d053ae4ae92aa848b5879e3ef3687c6203@89.117.49.48:30303
-enode://81edfecc3df6994679daf67858ae34c0ae91aac944a84b09171532b45ad0f5d0c896eb8c023df04eaa2db743f5fccdf18cf7e2d12120d37a2c142a3be0a348cd@38.102.87.174:30303
-enode://053ba696174e7f115e38f0e3963d0035ac20dc18e9a5c5873f9e90fe338d777f726d68d053c987416ec0bd97d4d818c59a8a23bc9ea854069ea2310846e27e7d@162.250.189.221:30303
-enode://b3ce1f8894af033cc2adbcb0836fe18d283af8574c451e385fd362165a6e5eded1b59b640c4d92048283bad9855721345a28ebaf28f66ace00a7134871d1e2a2@38.143.58.166:30303
-enode://938f2e3f409a12573e6da6460b6497c45e2bec393756b989b8874f647911cca39d0ffef8554a45698a8f21a7e870288beb638b3770537a12118e30bd6f9ae806@109.199.104.176:30303
-enode://47350ef305fb1406818a621a0f11144a72d560835a860607b331cef46ac82ea79c7df6bb5e5dba4147a489d9c77bc527f2500ce753fece817bc1a890eb05b886@185.252.233.29:30303
-enode://2ac0472c39e3e0be89bc021689d4c015c455e9f2fe2101bee80b61bba6224c810d200a6d6d17038d5826d522edbcb73a6bc44e492cd5f06a5377aa6eee03335b@144.126.136.27:30303
-enode://2c19c70a9c4134936926bbf1293e6fdc316401cc4f2cdb561dd5d2710f5b34ced22927173facabbeabe512f2e244994d65bc2f2d738db3bf805238f71fb9e490@205.172.57.65:30303
-enode://86ca3a228abf44c06fbf53544aca980b2473e17dcf84879835c0e7a366474727cdb3cf50c7d306dd079d75ba658efe5b9b896e44a9863c7eb025377d291f1eb5@167.224.64.233:30303
-enode://078efd1cbbd708c41bfc08f54f5610050804587bc8e30341501d34bbfdde68aa051de7a2c662b76dc47e822fe4f20ea85358abde11f7d52fbef74df54ad69469@162.250.189.152:30303
-enode://5f32d5fc76a951f07d3866a794809d70658acd8c8e843607dcc13e8f835725cca52cd1cdab0581f218ac9f689d2c1ec71e4fb5ee1d766222471b7e9c7a4f1098@104.152.209.76:30303
-enode://c8a53a7bd5f926f460816af8883e3c7d60753a8f8df04609e1e86f49a6def3c7029f732b2f045807895accf26da3145c8bcfd5a78691ecf39945e340812cf7e9@209.126.1.10:30303
-enode://f8848e405142b8e88f054fe85ac5e4a75cfd7e353aee7e66797719828d3d5aa2cd62f1355140c0852d3dcb2439a076234c77415ca701318ea1f69a496a0b4b32@109.123.232.199:30303
-enode://0857894c01314e75520fbdb7e37869666f230c8ab96c0e3067561077209e8f48a9cefb3a71c3c8094448629c152f22c2e5e66bb7ed2c38bfbd9f24941f571beb@103.7.54.103:30303
enode://91e59fa1b034ae35e9f4e8a99cc6621f09d74e76a6220abb6c93b29ed41a9e1fc4e5b70e2c5fc43f883cffbdcd6f4f6cbc1d23af077f28c2aecc22403355d4b1@81.0.220.137:30304📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| enode://e1a69a7d766576e694adc3fc78d801a8a66926cbe8f4fe95b85f3b481444700a5d1b6d440b2715b5bb7cf4824df6a6702740afc8c52b20c72bc8c16f1ccde1f3@149.102.140.32:30303 | |
| enode://874589626a2b4fd7c57202533315885815eba51dbc434db88bbbebcec9b22cf2a01eafad2fd61651306fe85321669a30b3f41112eca230137ded24b86e064ba8@5.189.144.192:30303 | |
| enode://ccdef92053c8b9622180d02a63edffb3e143e7627737ea812b930eacea6c51f0c93a5da3397f59408c3d3d1a9a381f7e0b07440eae47314685b649a03408cfdd@37.60.243.5:30303 | |
| enode://12711126475d7924af98d359e178f71c5d9607de32d2c5b4ab1afff4b0bb16b793b4bbda0a42bf41a309e5349b6106d053ae4ae92aa848b5879e3ef3687c6203@89.117.49.48:30303 | |
| enode://81edfecc3df6994679daf67858ae34c0ae91aac944a84b09171532b45ad0f5d0c896eb8c023df04eaa2db743f5fccdf18cf7e2d12120d37a2c142a3be0a348cd@38.102.87.174:30303 | |
| enode://053ba696174e7f115e38f0e3963d0035ac20dc18e9a5c5873f9e90fe338d777f726d68d053c987416ec0bd97d4d818c59a8a23bc9ea854069ea2310846e27e7d@162.250.189.221:30303 | |
| enode://b3ce1f8894af033cc2adbcb0836fe18d283af8574c451e385fd362165a6e5eded1b59b640c4d92048283bad9855721345a28ebaf28f66ace00a7134871d1e2a2@38.143.58.166:30303 | |
| enode://938f2e3f409a12573e6da6460b6497c45e2bec393756b989b8874f647911cca39d0ffef8554a45698a8f21a7e870288beb638b3770537a12118e30bd6f9ae806@109.199.104.176:30303 | |
| enode://47350ef305fb1406818a621a0f11144a72d560835a860607b331cef46ac82ea79c7df6bb5e5dba4147a489d9c77bc527f2500ce753fece817bc1a890eb05b886@185.252.233.29:30303 | |
| enode://2ac0472c39e3e0be89bc021689d4c015c455e9f2fe2101bee80b61bba6224c810d200a6d6d17038d5826d522edbcb73a6bc44e492cd5f06a5377aa6eee03335b@144.126.136.27:30303 | |
| enode://2c19c70a9c4134936926bbf1293e6fdc316401cc4f2cdb561dd5d2710f5b34ced22927173facabbeabe512f2e244994d65bc2f2d738db3bf805238f71fb9e490@205.172.57.65:30303 | |
| enode://86ca3a228abf44c06fbf53544aca980b2473e17dcf84879835c0e7a366474727cdb3cf50c7d306dd079d75ba658efe5b9b896e44a9863c7eb025377d291f1eb5@167.224.64.233:30303 | |
| enode://078efd1cbbd708c41bfc08f54f5610050804587bc8e30341501d34bbfdde68aa051de7a2c662b76dc47e822fe4f20ea85358abde11f7d52fbef74df54ad69469@162.250.189.152:30303 | |
| enode://5f32d5fc76a951f07d3866a794809d70658acd8c8e843607dcc13e8f835725cca52cd1cdab0581f218ac9f689d2c1ec71e4fb5ee1d766222471b7e9c7a4f1098@104.152.209.76:30303 | |
| enode://c8a53a7bd5f926f460816af8883e3c7d60753a8f8df04609e1e86f49a6def3c7029f732b2f045807895accf26da3145c8bcfd5a78691ecf39945e340812cf7e9@209.126.1.10:30303 | |
| enode://f8848e405142b8e88f054fe85ac5e4a75cfd7e353aee7e66797719828d3d5aa2cd62f1355140c0852d3dcb2439a076234c77415ca701318ea1f69a496a0b4b32@109.123.232.199:30303 | |
| enode://0857894c01314e75520fbdb7e37869666f230c8ab96c0e3067561077209e8f48a9cefb3a71c3c8094448629c152f22c2e5e66bb7ed2c38bfbd9f24941f571beb@103.7.54.103:30303 |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@mainnet/bootnodes.list` around lines 18 - 34, The file mainnet/bootnodes.list
contains exact duplicate enode entries (the block added in the diff duplicates
the first 17 entries); remove the duplicated block so each enode appears only
once in mainnet/bootnodes.list and verify start-node.sh (referenced as
start-node.sh:17-25) will still build the --bootnodes argument from the single,
unique list—ensure no other duplicates remain.
Comment on lines
+18
to
+34
| enode://e1a69a7d766576e694adc3fc78d801a8a66926cbe8f4fe95b85f3b481444700a5d1b6d440b2715b5bb7cf4824df6a6702740afc8c52b20c72bc8c16f1ccde1f3@149.102.140.32:30303 | ||
| enode://874589626a2b4fd7c57202533315885815eba51dbc434db88bbbebcec9b22cf2a01eafad2fd61651306fe85321669a30b3f41112eca230137ded24b86e064ba8@5.189.144.192:30303 | ||
| enode://ccdef92053c8b9622180d02a63edffb3e143e7627737ea812b930eacea6c51f0c93a5da3397f59408c3d3d1a9a381f7e0b07440eae47314685b649a03408cfdd@37.60.243.5:30303 | ||
| enode://12711126475d7924af98d359e178f71c5d9607de32d2c5b4ab1afff4b0bb16b793b4bbda0a42bf41a309e5349b6106d053ae4ae92aa848b5879e3ef3687c6203@89.117.49.48:30303 | ||
| enode://81edfecc3df6994679daf67858ae34c0ae91aac944a84b09171532b45ad0f5d0c896eb8c023df04eaa2db743f5fccdf18cf7e2d12120d37a2c142a3be0a348cd@38.102.87.174:30303 | ||
| enode://053ba696174e7f115e38f0e3963d0035ac20dc18e9a5c5873f9e90fe338d777f726d68d053c987416ec0bd97d4d818c59a8a23bc9ea854069ea2310846e27e7d@162.250.189.221:30303 | ||
| enode://b3ce1f8894af033cc2adbcb0836fe18d283af8574c451e385fd362165a6e5eded1b59b640c4d92048283bad9855721345a28ebaf28f66ace00a7134871d1e2a2@38.143.58.166:30303 | ||
| enode://938f2e3f409a12573e6da6460b6497c45e2bec393756b989b8874f647911cca39d0ffef8554a45698a8f21a7e870288beb638b3770537a12118e30bd6f9ae806@109.199.104.176:30303 | ||
| enode://47350ef305fb1406818a621a0f11144a72d560835a860607b331cef46ac82ea79c7df6bb5e5dba4147a489d9c77bc527f2500ce753fece817bc1a890eb05b886@185.252.233.29:30303 | ||
| enode://2ac0472c39e3e0be89bc021689d4c015c455e9f2fe2101bee80b61bba6224c810d200a6d6d17038d5826d522edbcb73a6bc44e492cd5f06a5377aa6eee03335b@144.126.136.27:30303 | ||
| enode://2c19c70a9c4134936926bbf1293e6fdc316401cc4f2cdb561dd5d2710f5b34ced22927173facabbeabe512f2e244994d65bc2f2d738db3bf805238f71fb9e490@205.172.57.65:30303 | ||
| enode://86ca3a228abf44c06fbf53544aca980b2473e17dcf84879835c0e7a366474727cdb3cf50c7d306dd079d75ba658efe5b9b896e44a9863c7eb025377d291f1eb5@167.224.64.233:30303 | ||
| enode://078efd1cbbd708c41bfc08f54f5610050804587bc8e30341501d34bbfdde68aa051de7a2c662b76dc47e822fe4f20ea85358abde11f7d52fbef74df54ad69469@162.250.189.152:30303 | ||
| enode://5f32d5fc76a951f07d3866a794809d70658acd8c8e843607dcc13e8f835725cca52cd1cdab0581f218ac9f689d2c1ec71e4fb5ee1d766222471b7e9c7a4f1098@104.152.209.76:30303 | ||
| enode://c8a53a7bd5f926f460816af8883e3c7d60753a8f8df04609e1e86f49a6def3c7029f732b2f045807895accf26da3145c8bcfd5a78691ecf39945e340812cf7e9@209.126.1.10:30303 | ||
| enode://f8848e405142b8e88f054fe85ac5e4a75cfd7e353aee7e66797719828d3d5aa2cd62f1355140c0852d3dcb2439a076234c77415ca701318ea1f69a496a0b4b32@109.123.232.199:30303 | ||
| enode://0857894c01314e75520fbdb7e37869666f230c8ab96c0e3067561077209e8f48a9cefb3a71c3c8094448629c152f22c2e5e66bb7ed2c38bfbd9f24941f571beb@103.7.54.103:30303 |
There was a problem hiding this comment.
Duplicate entries detected: Lines 18-34 are exact copies of lines 1-17.
The newly added enode entries are identical to the entries already present at the top of the file. For example:
- Line 18 duplicates Line 1 (
enode://e1a69a7d...@149.102.140.32:30303) - Line 19 duplicates Line 2 (
enode://874589...@5.189.144.192:30303) - ... and so on for all 17 entries
When peer.sh processes this file, it will call admin.addPeer() twice for each of these nodes, which is redundant and could cause unnecessary connection attempts.
🐛 Proposed fix: Remove duplicate entries
enode://0857894c01314e75520fbdb7e37869666f230c8ab96c0e3067561077209e8f48a9cefb3a71c3c8094448629c152f22c2e5e66bb7ed2c38bfbd9f24941f571beb@103.7.54.103:30303
-enode://e1a69a7d766576e694adc3fc78d801a8a66926cbe8f4fe95b85f3b481444700a5d1b6d440b2715b5bb7cf4824df6a6702740afc8c52b20c72bc8c16f1ccde1f3@149.102.140.32:30303
-enode://874589626a2b4fd7c57202533315885815eba51dbc434db88bbbebcec9b22cf2a01eafad2fd61651306fe85321669a30b3f41112eca230137ded24b86e064ba8@5.189.144.192:30303
-enode://ccdef92053c8b9622180d02a63edffb3e143e7627737ea812b930eacea6c51f0c93a5da3397f59408c3d3d1a9a381f7e0b07440eae47314685b649a03408cfdd@37.60.243.5:30303
-enode://12711126475d7924af98d359e178f71c5d9607de32d2c5b4ab1afff4b0bb16b793b4bbda0a42bf41a309e5349b6106d053ae4ae92aa848b5879e3ef3687c6203@89.117.49.48:30303
-enode://81edfecc3df6994679daf67858ae34c0ae91aac944a84b09171532b45ad0f5d0c896eb8c023df04eaa2db743f5fccdf18cf7e2d12120d37a2c142a3be0a348cd@38.102.87.174:30303
-enode://053ba696174e7f115e38f0e3963d0035ac20dc18e9a5c5873f9e90fe338d777f726d68d053c987416ec0bd97d4d818c59a8a23bc9ea854069ea2310846e27e7d@162.250.189.221:30303
-enode://b3ce1f8894af033cc2adbcb0836fe18d283af8574c451e385fd362165a6e5eded1b59b640c4d92048283bad9855721345a28ebaf28f66ace00a7134871d1e2a2@38.143.58.166:30303
-enode://938f2e3f409a12573e6da6460b6497c45e2bec393756b989b8874f647911cca39d0ffef8554a45698a8f21a7e870288beb638b3770537a12118e30bd6f9ae806@109.199.104.176:30303
-enode://47350ef305fb1406818a621a0f11144a72d560835a860607b331cef46ac82ea79c7df6bb5e5dba4147a489d9c77bc527f2500ce753fece817bc1a890eb05b886@185.252.233.29:30303
-enode://2ac0472c39e3e0be89bc021689d4c015c455e9f2fe2101bee80b61bba6224c810d200a6d6d17038d5826d522edbcb73a6bc44e492cd5f06a5377aa6eee03335b@144.126.136.27:30303
-enode://2c19c70a9c4134936926bbf1293e6fdc316401cc4f2cdb561dd5d2710f5b34ced22927173facabbeabe512f2e244994d65bc2f2d738db3bf805238f71fb9e490@205.172.57.65:30303
-enode://86ca3a228abf44c06fbf53544aca980b2473e17dcf84879835c0e7a366474727cdb3cf50c7d306dd079d75ba658efe5b9b896e44a9863c7eb025377d291f1eb5@167.224.64.233:30303
-enode://078efd1cbbd708c41bfc08f54f5610050804587bc8e30341501d34bbfdde68aa051de7a2c662b76dc47e822fe4f20ea85358abde11f7d52fbef74df54ad69469@162.250.189.152:30303
-enode://5f32d5fc76a951f07d3866a794809d70658acd8c8e843607dcc13e8f835725cca52cd1cdab0581f218ac9f689d2c1ec71e4fb5ee1d766222471b7e9c7a4f1098@104.152.209.76:30303
-enode://c8a53a7bd5f926f460816af8883e3c7d60753a8f8df04609e1e86f49a6def3c7029f732b2f045807895accf26da3145c8bcfd5a78691ecf39945e340812cf7e9@209.126.1.10:30303
-enode://f8848e405142b8e88f054fe85ac5e4a75cfd7e353aee7e66797719828d3d5aa2cd62f1355140c0852d3dcb2439a076234c77415ca701318ea1f69a496a0b4b32@109.123.232.199:30303
-enode://0857894c01314e75520fbdb7e37869666f230c8ab96c0e3067561077209e8f48a9cefb3a71c3c8094448629c152f22c2e5e66bb7ed2c38bfbd9f24941f571beb@103.7.54.103:30303
enode://91e59fa1b034ae35e9f4e8a99cc6621f09d74e76a6220abb6c93b29ed41a9e1fc4e5b70e2c5fc43f883cffbdcd6f4f6cbc1d23af077f28c2aecc22403355d4b1@81.0.220.137:30304🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@mainnet/enode.txt` around lines 18 - 34, The file contains a duplicated block
of enode entries (the second block starting with enode://e1a69a7d7665... and
repeating the same 17 entries) which will cause peer.sh to call admin.addPeer()
twice for each node; remove the duplicate entries so each enode string appears
only once (keep the first occurrence of each enode like enode://e1a69a7d7665...
and delete the repeated block), ensuring the remaining list contains only unique
enode entries to avoid redundant addPeer calls.
Contributor
|
we should update files in https://github.com/XinFinOrg/XDPoSChain also:
|
wanwiset25
approved these changes
Mar 6, 2026
25 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit