Fix #537: protect rutor state with RWMutex to avoid concurrent map writes #653
+106
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rutor search was crashing with "fatal error: concurrent map writes" when
the index was updated (loadDB/updateDB) while Search or other readers
accessed shared state (torrs slice and torrsearch index) from other goroutines.
writes of torrs, isStop, and torrsearch index in Start, Stop, updateDB,
loadDB, and Search.
sees a half-updated state.
Add TestConcurrentSearchAndLoadDB to verify there is no data race between
concurrent loadDB and Search; run with: go test -race -count=3.