fix: enable gemini multi-turn tool calling via bidiAppend session resume#12
Open
FL-Penly wants to merge 1 commit intoYukaii:mainfrom
Open
fix: enable gemini multi-turn tool calling via bidiAppend session resume#12FL-Penly wants to merge 1 commit intoYukaii:mainfrom
FL-Penly wants to merge 1 commit intoYukaii:mainfrom
Conversation
Previously, when tool results arrived in a new request, the handler unconditionally destroyed the existing session and started a fresh Cursor stream. This caused gemini models to fail at multi-turn tool calling - they would loop or error after the first tool result. The fix uses the already-implemented sendToolResultsToCursor() from session-reuse.ts to send tool results back via bidiAppend on the existing session, then calls sendResumeAction() to trigger server continuation. Falls back to the original fresh-start behavior if the session is gone or resume fails. Tested with cursor/gemini-3-flash and cursor/gemini-3.1-pro, both now correctly complete multi-turn tool call sequences. Fixes Yukaii#7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
Gemini models fail at multi-turn tool calling because when tool results arrive, the handler unconditionally destroys the session and starts a fresh stream. Gemini then re-requests the same tool instead of continuing.
session-reuse.tsalready hadsendToolResultsToCursor()implemented but never wired up. This PR uses it to send tool results back via bidiAppend + sendResumeAction on the existing session, falling back to fresh-start if the session is gone or resume fails.