fix: Puell Multiple indicator range regression (#22)#25
fix: Puell Multiple indicator range regression (#22)#25Emivvvvv wants to merge 4 commits intoZaczero:mainfrom
Conversation
|
We talked with Colin and it turns out we thought of modeling price versus metric peaks some time ago (years back), and the decision was to model the price highs, allowing for metrics to go above 100% and just clip them. |
|
@ColinTalksCrypto @Zaczero thank you for your clear explanation of your decision making point about Puell Multiple. I agree with you. My goal was just to make it similar to other examples but for CBBI, this makes a lot of sense. Since all of the indicators are optional in the website, the indicator being a little bit outdated should be fine. On this—and it is a bit out of topic—maybe if the outdated indicator numbers become a couple instead of one, there might be another default just for the "better" indicators. This is a completely new idea, I know, but I just wanted to mention it. I'm a huge fan of the idea of CBBI and would like to help it become a better platform overall. Feel free to close this PR if we agreed that the current way is the way to go. Best! |

This PR fixes issue #22
The Issue:
The "High Model" math incorrectly assumed diminishing returns would follow a permanent straight line, resulting in a ceiling that was far too low for the current cycle.
The Fix:
Verification:
I compared the old logic vs the new logic on historical data. The chart below shows how the Old Version (Red) spiked to unrealistic levels (because the ceiling model collapsed), while the New Version (Green) remains stable and realistic.