fix: resolve non-constant IconData preventing icon font tree-shaking#427
Merged
Merged
Conversation
Contributor
PR Checks complete
Created with Flutter code quality action |
Contributor
|
Visit the preview URL for this PR (updated for commit ffa3acc): https://zeta-flutter-main--pr-427-fix-icon-tree-shaking-v2-681kxe4i.web.app (expires Tue, 14 Apr 2026 12:34:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5ca681de0a0ad9185b252304c113355d5ee04ca6 |
248a62d to
ceb4f15
Compare
ceb4f15 to
ffa3acc
Compare
thelukewalton
approved these changes
Apr 7, 2026
thelukewalton
added a commit
that referenced
this pull request
Apr 7, 2026
🤖 I have created a release *beep* *boop* --- ## [1.4.5](zeta_flutter-v1.4.4...zeta_flutter-v1.4.5) (2026-04-07) ### 🪲 Bug Fixes * resolve non-constant IconData preventing icon font tree-shaking ([#427](#427)) ([3ecabf1](3ecabf1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_copyWith()inIconExtensions.apply()with a lookup into consticonsRound/iconsSharpmaps, eliminating non-constantIconDataconstruction that broke--tree-shake-iconsiconsRoundandiconsSharpcodePoint lookup maps tozeta_icons(will be auto-generated by the zeta-icons template going forward)IconDatain example app withZetaIconwidgetzeta_icons1.9.2 → 1.9.3,zeta_flutter1.4.4 → 1.4.5Fixes the Flutter web release build error:
Depends on
Test plan
flutter build web --release --tree-shake-iconssucceedsflutter analyzepasses with no issues