Open
Conversation
ZechangSun
reviewed
Feb 23, 2023
preprocess.py
Outdated
| def overlap(sightline, data:DesiMock, id): | ||
| ''' | ||
| here sightline = data.get_sightline(id=id) | ||
| Deal with the overlapping area between different cameras so that the result will not contain the overlaps. |
Owner
There was a problem hiding this comment.
- please move
get_split_pointandget_betweenoutside theoverlapfunction - documents are required for
get_split_pointandget_betweenfunction - have you ever visually tested for a large number of mock spectra that using the average points to split the two camera is correct, i.e., no wired features?
ZechangSun
reviewed
Feb 23, 2023
preprocess.py
Outdated
| # plt.axvline(LyALPHA*(1+sightline.z_qso), linestyle='--') | ||
|
|
||
| def clip(sightline, unit_default=100, slope=2e-3, plot=False): | ||
| def clip(sightline, unit_default=100, slope=2e-3, ratio=0.5, plot=False): |
Owner
There was a problem hiding this comment.
Also, I don't think it's necessary to add line_fit as a inner function
ZechangSun
reviewed
Feb 23, 2023
Owner
ZechangSun
left a comment
ZechangSun
left a comment
There was a problem hiding this comment.
I think it will be better to copy those codes e.g., DESIMOCK from dla_cnn to the data folder. dlc_cnn is another repo to find damped Lya systems in DESI, and it's wired to have it in our folder.
Move some assisting function outside and write them docs.
delete the parameter "plot" and the redundant function "line_fit"
pack them into a json file
From np.log to np.log10
Make it more flexible.
Bug: ignore the last element of the original array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including dealing with overlap areas, sigmacliping and rebinning to the same restframe
Also convert the catalog.ipynb to .py