Only look for env vars that *start* with BUILDKITE #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than filtering env vars to pass to buildkite-pyyaml by those that *contain* the string BUILDKITE, filter to variables that *start* with BUILDKITE, using the -0 flag to env and the -z flag to grep to delimit the variables by null characters rather than newlines so we don't also grab lines inside multi-line env vars (such as the commit message)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to:
cc: @zegocover/git-diff-conditional-buildkite-plugin-maintainers
related to:
resolves: #21
Rather than filtering env vars to pass to buildkite-pyyaml by those that
contain the string BUILDKITE, filter to variables that start with
BUILDKITE, using the -0 flag to env and the -z flag to grep to delimit
the variables by null characters rather than newlines so we don't also
grab lines inside multi-line env vars (such as the commit message)