Skip to content

🎨 Palette: Replace hardcoded technical notification text with standard localized UX phrasing #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manupawickramasinghe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🎨 Palette: Replace hardcoded technical notification text with standard localized UX phrasing #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ff1c59
Extract notification strings and update wording
google-labs-jules[bot] May 30, 2026
688c76c
Extract notification strings and update wording
google-labs-jules[bot] May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,3 +146,7 @@
## 2026-05-20 - Mouse Hover States for Custom Selectors
**Learning:** Custom drawable selectors (like `ic_shutter.xml`) on Android often define `state_pressed` and `state_focused` but omit `state_hovered`. This strips visual feedback for users navigating with pointer devices (mice, trackpads) on environments like Chromebooks or Samsung DeX, degrading the user experience compared to native components.
**Action:** Always include `android:state_hovered="true"` alongside focus and pressed states in custom interactive background selectors to ensure universal visual feedback across all input methods.

## 2026-05-30 - User-Facing Notification Terminology
**Learning:** Hardcoded, technical, or aggressive terminology (like "Kill" for stopping a service or "Click" when tapping a touchscreen) in user-facing system notifications and foreground service controls creates a jarring and confusing experience. Sighted users are exposed to technical jargon, and screen readers read aggressive language out of context.
**Action:** Always avoid hardcoded technical phrasing in notification titles, descriptions, and actions. Utilize standard mobile UX phrasing (e.g., "Stop", "Tap to open") and ensure all notification text is extracted to localized string resources.
10 changes: 5 additions & 5 deletions app/src/main/java/com/samsung/android/scan3d/serv/Cam.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ class Cam : Service() {
"start" -> {
val channel = NotificationChannel(
CHANNEL_ID,
CHANNEL_ID,
getString(R.string.notification_channel_name),
NotificationManager.IMPORTANCE_DEFAULT
)
channel.description = "RemoteCam run"
channel.description = getString(R.string.notification_channel_desc)
val notificationManager = getSystemService(NotificationManager::class.java)
notificationManager.createNotificationChannel(channel)

Expand All @@ -72,9 +72,9 @@ class Cam : Service() {

val builder =
NotificationCompat.Builder(this, CHANNEL_ID)
.setContentTitle("RemoteCam (active)")
.setContentText("Click to open").setOngoing(true)
.setSmallIcon(R.drawable.ic_linked_camera).addAction(R.drawable.ic_close, "Kill",pendingIntentKill)
.setContentTitle(getString(R.string.notification_title))
.setContentText(getString(R.string.notification_content)).setOngoing(true)
.setSmallIcon(R.drawable.ic_linked_camera).addAction(R.drawable.ic_close, getString(R.string.notification_action_stop),pendingIntentKill)
.setContentIntent(pendingIntent)


Expand Down
7 changes: 7 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,11 @@
<string name="frame_time_format">%1$d ms</string>
<string name="bitrate_format">%1$d kB/sec</string>
<string name="quality_format">%1$d%%</string>

<!-- Notification Strings -->
<string name="notification_channel_name">RemoteCam Service</string>
<string name="notification_channel_desc">RemoteCam running in background</string>
<string name="notification_title">RemoteCam (active)</string>
<string name="notification_content">Tap to open</string>
<string name="notification_action_stop">Stop</string>
</resources>