Refactor j ea profile j ea consumption j ea production #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And some minor updates to slider code getters for profile yearly consumption.
GillisHommen
deleted the
Refactor-J_EAProfile-J_EAConsumption-J_EAProduction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor related to engine changes in:
To be combined with: Zenmo/zero_engine#243
Also: J_EAProfile now also uses profilePointer with tableFunction to reach the time series data. Hourly data is kept in hourly format, as the tableFunction can do interpolation in the time-axis. Not using 'fudgeIt' function anymore, although now some checks are missing; like checking the startdate of a timeseries. Best way forward is to 'embrace' the code Erik made to do these checks in a more transparant fashion for us as modelers.
So far, checked with Genius model, gives identical output to current main.