-
Notifications
You must be signed in to change notification settings - Fork 164
rpi net: networks scan and interrupt mode #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ianic
wants to merge
17
commits into
ZigEmbeddedGroup:main
Choose a base branch
from
ianic:wifi_scan
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Lint Results
Found 1 issue on changed lines in 1 file:
- drivers/wireless/cyw43439/ioctl.zig: 1 issue
Besides blocking wifi join we can now poll for the join status while still have option to do another work between polls.
During join and later in recv. We can now detect disconnect, reconnect and set connected state.
Make them both return has more flag.
2 + len when len is u8 can overflow
Handle scan/join in the same function. Add join_state and scan_result to the main struct.
Fix todo: move country option to init. Rename methods, join and scan are no blocking returning poller. Blocking join is now join_wait.
Report status after init, not also during init. Remember last status and de-duplicate. Remove error log which is also passed to the application.
Use that state to set lwip link up/down.
Handling cyw43 data packet receive interrupts.
vtable is `*const Vtable` making it runtime known makes that local variable. Making it comptime known const.
Partially reverting changes from ZigEmbeddedGroup#861. Macros set on net module are not visible when building lwip. For example setting `net_mod.addCMacro("MEM_ALIGNMENT", "4");` gets lwip build with default 1 of MEM_ALIGNMENT. Changed to setting that on lwip module instead of net module. Later I also copied that to the net module because it is needed when using cImport in net package. Without that it also gets default if I check `lwip.MEM_ALIGNMENT` somewhere in src/root.zig.
Suggested by lint results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds few more features to the rpi pico WiFi driver:
There are two new examples:
scanlists available WiFi networksirqshows how to use interrupt mode, interrupt is fired when there is data packet to read from cyw43