ch32 USBHD/USBHS driver implementation#893
Draft
Copper280z wants to merge 88 commits into
Draft
Conversation
…into origin/umain
…oards. ch32 USBHS still sends packets twice.
…ual mode. CDC Works without extra packets!
…ed code in usb_cdc.zig
Lint ResultsFound 12 issues on changed lines in 4 files:
|
…ng to board definitions, add max packet size to usb device hal.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| _reserved1: u2 = 0, | ||
| }); | ||
|
|
||
| fn baseAddr() usize { |
There was a problem hiding this comment.
Please change to base_addr, in MicroZig we use snake case for function names.
Collaborator
There was a problem hiding this comment.
this one actually makes sense
Grazfather
reviewed
Feb 10, 2026
Collaborator
Grazfather
left a comment
Grazfather
left a comment
There was a problem hiding this comment.
Reviewed everything except for the HALs themselves (since this is a draft). Will get to those when you think they're ready.
Comment on lines
+114
to
+116
| // pins.tog.put(0); | ||
| usb_dev.poll(false, &usb_controller); | ||
| // pins.tog.put(1); |
Collaborator
There was a problem hiding this comment.
gets rid of toggle pins completely or uncomment these please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new driver for the ch32 USBHD/USBHS peripheral, USB_OTG_FS peripheral, and examples for the ch32v307, and ch32v203 boards.