Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/agent_execution/active_task.py | 94.65% | 94.06% | 🔴 -0.59% |
| src/a2a/server/events/event_queue.py | 95.51% | 91.01% | 🔴 -4.49% |
| Total | 92.32% | 92.25% | 🔴 -0.07% |
Generated by coverage-comment.yml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the event queue architecture by migrating functional dependencies and type hints from the EventQueue base class to EventQueueLegacy across the server and test suites. Additionally, it updates event_queue_v2.py to include detailed docstrings with deadlock warnings for the close and aexit methods, while marking is_closed as deprecated. I have no feedback to provide.
bartek-w
force-pushed
the
bartekw-event-queue-simplified
branch
from
57701e5 to
aa7bed8
Compare
ishymko
approved these changes
Apr 8, 2026
bartek-w
force-pushed
the
bartekw-event-queue-simplified
branch
2 times, most recently
from
f4d3182 to
57f4cdb
Compare
bartek-w
force-pushed
the
bartekw-event-queue-simplified
branch
from
57f4cdb to
9064e0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #869 🦕