fix: fix JSONRPC error handling#957
Merged
guglielmo-san merged 8 commits intoa2aproject:1.0-devfrom Apr 9, 2026
Merged
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/client/transports/http_helpers.py | 89.74% | 93.59% | 🟢 +3.85% |
| src/a2a/client/transports/jsonrpc.py | 90.07% | 91.39% | 🟢 +1.32% |
| src/a2a/server/routes/jsonrpc_dispatcher.py | 85.16% | 85.71% | 🟢 +0.56% |
| Total | 92.33% | 92.39% | 🟢 +0.07% |
Generated by coverage-comment.yml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the streaming request processing in the JSON-RPC dispatcher to eagerly fetch the first event, ensuring that validation errors are caught upfront rather than after the stream has started. It also includes a new integration test to verify this behavior. I have suggested using the specific Protobuf base class for type hints instead of 'Any' to improve type safety and adhere to repository standards.
ishymko
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do one iteration to catch exceptions occurred beforehand to return an error instead of sending headers for SSE.