Add numeric type cases to CustomTypeSerializer#62
Merged
Conversation
Piiit
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from #61.
CustomTypeSerializer.serialize()was missing explicit handling for numeric types (Byte,Short,Integer,Long,Float,Double,BigInteger,BigDecimal,ScaledBigDecimal). These fell through to the genericwriteRawValue()branch, causing numeric-wrappedCustomType<?>values to be serialized as JSON strings instead of JSON numbers.This port adds the nine missing
casebranches, each callingwriteNumber()with the appropriately typed value. The implementation is adapted from the v1 branch fix (PR #61) to the Jackson 3.x API used inmain(tools.jackson.*,ValueSerializer,SerializationContext, nothrows IOException). Nocase nullbranch was added — the value is@NonNullper jspecify and the null case is not applicable in this branch.Review notes
This PR ports an existing change into this project. Please focus on: