Fix: If ticket/1 is inaccessible, roust would throw in authenticated #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
authenticated?in roust.rb would check for anUnauthenticatedexception thrown from the functionshow('1').However, if an http request to
ticket/1returns a# You are not allowed to display ticket 1.,ticket_show('1')would continue to callparse_ticket_attributeswhich happily tries to expand the response body, creates ahash = body_to_hash(body)assuming that anid = ticket/1field is present in the response body.Once it tries to access its 'id' key in
hash['id'] = hash['id'].split('/').last, it throwsundefined methodsplit' for nil:NilClass`.Additionally, if the ticket/1 is not present at all,
authenticated?would untruthfully not return true, because theif show('1')test fails.This patch prevents
ticket_show()to continue if the ticket is disallowed and properly returns true inauthenticate?, if no exception is thrown.