Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eval/stream-bench/) for evaluating ACE on text-to-SQL tasks using the StreamBench suite, supporting the BIRD, CoSQL, and Spider datasetsace.py,reflector.py,llm.py,utils.py) with improvements needed for text-to-SQL evaluation: per-split data processors, SQL execution result passing to the reflector, more robust LLM error handling (HTTP 400 / invalid prompt recovery), and enriched run folder namingChanges
New:
eval/stream-bench/run.pyrun_playbook.pydata_processor.pydownload_text2sql_data.pypreprocess_streambench_{bird,cosql,spider}.py.jsonlwith schemadataset_stats.pyplot.pyanalyze_logs.pydata/bird_config.jsondata/cosql_config.jsondata/spider_config.jsonREADME.mdModified: ACE core
ace/ace.py: Support separatetrain_processor/val_processor/test_processor(backward-compatible withdata_processor); pass metadata (db_nameandcurriculum) into run folder name; printcorrect/totalcounts alongside accuracyace/core/reflector.py: Accept and format SQL execution results (predicted_result,ground_truth_result) and pass them into the reflector prompt for richer feedbackace/prompts/reflector.py: Add SQL execution results placeholder to both ground-truth and no-ground-truth reflector prompt templatesllm.py: Detect and gracefully handle HTTP 400 / invalid-prompt / policy-violation errors without crashing; skip the affected sample and continue executionutils.py: Minor utilities supporting stream-bench evaluation